chrome/installer/mini_installer/mini_installer.cc - Issue 780983002: Initialize 'ret' to avoid possible uninitialized read.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mini_installer/mini_installer.cc

Issue 780983002: Initialize 'ret' to avoid possible uninitialized read. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/mini_installer/mini_installer.cc

diff --git a/chrome/installer/mini_installer/mini_installer.cc b/chrome/installer/mini_installer/mini_installer.cc

index e00569c7fad3d1da3206835dc2c8282ea2ee7329..2738c4d2e42ea83d3f608d9f930e4dc39e168c05 100644

--- a/chrome/installer/mini_installer/mini_installer.cc

+++ b/chrome/installer/mini_installer/mini_installer.cc

@@ -169,7 +169,7 @@ void SetInstallerFlags(const Configuration& configuration) {

google_update::kChromeFrameAppGuid :

configuration.chrome_app_guid();

StackString<128> value;

- LONG ret;

+ LONG ret = ERROR_SUCCESS;

// When multi_install is true, we are potentially:

// 1. Performing a multi-install of some product(s) on a clean machine.

« no previous file with comments | « no previous file | no next file » | no next file with comments »