Issue 780783004: Push service may be null and must only be used on the UI thread.

Issue 780783004: Push service may be null and must only be used on the UI thread. (Closed)

Created:
6 years ago by Michael van Ouwerkerk

Modified:
6 years ago

Reviewers:
Peter Beverloo, Avi (use Gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Push service may be null and must only be used on the UI thread. TBR=avi@chromium.org for comment-only change in content/public Committed: https://crrev.com/0ff3a49d8878743613b0f7c51be052ff1b1c6f10 Cr-Commit-Position: refs/heads/master@{#307037}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
M	content/browser/push_messaging/push_messaging_message_filter.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/push_messaging/push_messaging_message_filter.cc	View	1	3 chunks	+10 lines, -0 lines	0 comments	Download
M	content/public/browser/push_messaging_service.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 10 (3 generated)

Michael van Ouwerkerk

Avi, could you take a look please as owner of content/public/browser/push_messaging_service.h?

6 years ago (2014-12-05 16:35:43 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780783004/20001

6 years ago (2014-12-05 16:42:20 UTC) #7

commit-bot: I haz the power

6 years ago (2014-12-05 17:26:12 UTC) #10

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/0ff3a49d8878743613b0f7c51be052ff1b1c6f10
Cr-Commit-Position: refs/heads/master@{#307037}