Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.h

Issue 780783004: Push service may be null and must only be used on the UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/push_messaging/push_messaging_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/push_messaging/push_messaging_message_filter.h
diff --git a/content/browser/push_messaging/push_messaging_message_filter.h b/content/browser/push_messaging/push_messaging_message_filter.h
index 60ea948ad1dd0a435b869c20a0b1d41f3cf3d411..85134e37bf68013e1370f685c5f58bc0cec53253 100644
--- a/content/browser/push_messaging/push_messaging_message_filter.h
+++ b/content/browser/push_messaging/push_messaging_message_filter.h
@@ -82,6 +82,9 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
void SendRegisterSuccess(const RegisterData& data,
const std::string& push_registration_id);
+ // Returns a push messaging service. The embedder owns the service, and is
+ // responsible for ensuring that it outlives RenderProcessHost. It's valid to
+ // return NULL. Must be called on the UI thread.
PushMessagingService* service();
int render_process_id_;
« no previous file with comments | « no previous file | content/browser/push_messaging/push_messaging_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698