Fix remaining WeakPtrFactory ordering problems

chrome/browser/sync/sessions/session_data_type_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/memory/weak_ptr.h"
 #include "base/run_loop.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/sync/glue/synced_window_delegate.h"
@@ skipping 65 matching lines @@
  private:
   std::set<SyncedWindowDelegate*> delegates_;
 };
 
 class SessionDataTypeControllerTest
     : public testing::Test {
  public:
   SessionDataTypeControllerTest()
       : load_finished_(false),
         thread_bundle_(content::TestBrowserThreadBundle::DEFAULT),
-        weak_ptr_factory_(this),
-        last_type_(syncer::UNSPECIFIED) {}
+        last_type_(syncer::UNSPECIFIED),
+        weak_ptr_factory_(this) {}
   ~SessionDataTypeControllerTest() override {}
 
   void SetUp() override {
     synced_window_delegate_.reset(new MockSyncedWindowDelegate(&profile_));
     synced_window_getter_.reset(new MockSyncedWindowDelegatesGetter());
     synced_window_getter_->Add(synced_window_delegate_.get());
 
     local_device_.reset(new LocalDeviceInfoProviderMock(
         "cache_guid",
         "Wayne Gretzky's Hacking Box",
@@ skipping 57 matching lines @@
   scoped_refptr<SessionDataTypeController> controller_;
   scoped_ptr<MockSyncedWindowDelegatesGetter> synced_window_getter_;
   scoped_ptr<LocalDeviceInfoProviderMock> local_device_;
   scoped_ptr<MockSyncedWindowDelegate> synced_window_delegate_;
   bool load_finished_;
 
  private:
   content::TestBrowserThreadBundle thread_bundle_;
   ProfileSyncComponentsFactoryMock profile_sync_factory_;
   TestingProfile profile_;
-  base::WeakPtrFactory<SessionDataTypeControllerTest> weak_ptr_factory_;
   syncer::ModelType last_type_;
   syncer::SyncError last_error_;
+  base::WeakPtrFactory<SessionDataTypeControllerTest> weak_ptr_factory_;
 };
 
 TEST_F(SessionDataTypeControllerTest, StartModels) {
   Start();
   EXPECT_EQ(sync_driver::DataTypeController::MODEL_LOADED,
             controller_->state());
   EXPECT_TRUE(LoadResult());
 }
 
 TEST_F(SessionDataTypeControllerTest, StartModelsDelayedByLocalDevice) {
@@ skipping 58 matching lines @@
 
   local_device_->SetInitialized(true);
   EXPECT_EQ(sync_driver::DataTypeController::MODEL_LOADED,
             controller_->state());
   EXPECT_TRUE(LoadResult());
 }
 
 }  // namespace
 
 }  // namespace browser_sync