content/browser/streams/stream_url_request_job.h - Issue 780713002: Fix remaining WeakPtrFactory ordering problems

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/streams/stream_url_request_job.h

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove flag change, merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/renderer_host/p2p/socket_host.cc ('k') | content/browser/streams/stream_url_request_job.cc » ('j') | content/renderer/media/remote_media_stream_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_STREAMS_STREAM_URL_REQUEST_JOB_H_	5 #ifndef CONTENT_BROWSER_STREAMS_STREAM_URL_REQUEST_JOB_H_

6 #define CONTENT_BROWSER_STREAMS_STREAM_URL_REQUEST_JOB_H_	6 #define CONTENT_BROWSER_STREAMS_STREAM_URL_REQUEST_JOB_H_

7	7

8 #include "net/http/http_status_code.h"	8 #include "net/http/http_status_code.h"

9 #include "net/url_request/url_request_job.h"	9 #include "net/url_request/url_request_job.h"

10 #include "content/browser/streams/stream_read_observer.h"	10 #include "content/browser/streams/stream_read_observer.h"

(...skipping 26 matching lines...) Expand all Loading...
37	37

38 protected:	38 protected:

39 ~StreamURLRequestJob() override;	39 ~StreamURLRequestJob() override;

40	40

41 private:	41 private:

42 void DidStart();	42 void DidStart();

43 void NotifyFailure(int);	43 void NotifyFailure(int);

44 void HeadersCompleted(net::HttpStatusCode status_code);	44 void HeadersCompleted(net::HttpStatusCode status_code);

45 void ClearStream();	45 void ClearStream();

46	46

47 base::WeakPtrFactory<StreamURLRequestJob> weak_factory_;

48 scoped_refptr<content::Stream> stream_;	47 scoped_refptr<content::Stream> stream_;

49 bool headers_set_;	48 bool headers_set_;

50 scoped_refptr<net::IOBuffer> pending_buffer_;	49 scoped_refptr<net::IOBuffer> pending_buffer_;

51 int pending_buffer_size_;	50 int pending_buffer_size_;

52 scoped_ptr<net::HttpResponseInfo> response_info_;	51 scoped_ptr<net::HttpResponseInfo> response_info_;

53	52

54 int total_bytes_read_;	53 int total_bytes_read_;

55 int max_range_;	54 int max_range_;

56 bool request_failed_;	55 bool request_failed_;

57	56

	57 base::WeakPtrFactory<StreamURLRequestJob> weak_factory_;

	58

58 DISALLOW_COPY_AND_ASSIGN(StreamURLRequestJob);	59 DISALLOW_COPY_AND_ASSIGN(StreamURLRequestJob);

59 };	60 };

60	61

61 } // namespace content	62 } // namespace content

62	63

63 #endif // CONTENT_BROWSER_STREAMS_STREAM_URL_REQUEST_JOB_H_	64 #endif // CONTENT_BROWSER_STREAMS_STREAM_URL_REQUEST_JOB_H_

OLD	NEW