Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 780483002: Remove the CSSOM. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove the CSSOM. This leaves CSSValue, but removes everything else. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b091f0d20cc0086bff3271aadfe801fef79062ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -3202 lines) Patch
D sky/engine/bindings/core/v8/custom/V8CSSRuleCustom.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
D sky/engine/bindings/core/v8/custom/V8StyleSheetCustom.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
M sky/engine/bindings/core/v8/custom/custom.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/animation/css/CSSAnimations.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/core.gni View 8 chunks +6 lines, -37 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/engine/core/css/CSSFilterRule.h View 1 chunk +0 lines, -68 lines 0 comments Download
D sky/engine/core/css/CSSFilterRule.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
D sky/engine/core/css/CSSFilterRule.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D sky/engine/core/css/CSSFontFaceRule.h View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/engine/core/css/CSSFontFaceRule.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
D sky/engine/core/css/CSSFontFaceRule.idl View 1 chunk +0 lines, -25 lines 0 comments Download
D sky/engine/core/css/CSSGroupingRule.h View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/core/css/CSSGroupingRule.cpp View 1 chunk +0 lines, -149 lines 0 comments Download
D sky/engine/core/css/CSSKeyframeRule.h View 1 chunk +0 lines, -101 lines 0 comments Download
D sky/engine/core/css/CSSKeyframeRule.cpp View 1 chunk +0 lines, -167 lines 0 comments Download
D sky/engine/core/css/CSSKeyframeRule.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D sky/engine/core/css/CSSKeyframesRule.h View 1 chunk +0 lines, -115 lines 0 comments Download
D sky/engine/core/css/CSSKeyframesRule.cpp View 1 chunk +0 lines, -207 lines 0 comments Download
D sky/engine/core/css/CSSKeyframesRule.idl View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/engine/core/css/CSSMediaRule.h View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/engine/core/css/CSSMediaRule.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D sky/engine/core/css/CSSMediaRule.idl View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/engine/core/css/CSSRule.h View 1 chunk +0 lines, -109 lines 0 comments Download
D sky/engine/core/css/CSSRule.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/engine/core/css/CSSRule.idl View 1 chunk +0 lines, -45 lines 0 comments Download
D sky/engine/core/css/CSSRuleList.h View 1 chunk +0 lines, -111 lines 0 comments Download
D sky/engine/core/css/CSSRuleList.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/engine/core/css/CSSRuleList.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M sky/engine/core/css/CSSStyleDeclaration.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSStyleDeclaration.idl View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/css/CSSStyleRule.h View 1 chunk +0 lines, -68 lines 0 comments Download
D sky/engine/core/css/CSSStyleRule.cpp View 1 chunk +0 lines, -133 lines 0 comments Download
D sky/engine/core/css/CSSStyleRule.idl View 1 chunk +0 lines, -25 lines 0 comments Download
M sky/engine/core/css/CSSStyleSheet.h View 9 chunks +0 lines, -33 lines 0 comments Download
M sky/engine/core/css/CSSStyleSheet.cpp View 7 chunks +0 lines, -175 lines 0 comments Download
D sky/engine/core/css/CSSStyleSheet.idl View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/engine/core/css/CSSSupportsRule.h View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/engine/core/css/CSSSupportsRule.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/engine/core/css/CSSSupportsRule.idl View 1 chunk +0 lines, -38 lines 0 comments Download
M sky/engine/core/css/CSSTestHelper.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/css/CSSUnknownRule.h View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/engine/core/css/CSSUnknownRule.idl View 1 chunk +0 lines, -25 lines 0 comments Download
M sky/engine/core/css/ElementRuleCollector.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/ElementRuleCollector.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/MediaList.h View 3 chunks +1 line, -19 lines 0 comments Download
M sky/engine/core/css/MediaList.cpp View 2 chunks +0 lines, -59 lines 0 comments Download
D sky/engine/core/css/MediaList.idl View 1 chunk +0 lines, -38 lines 0 comments Download
M sky/engine/core/css/PropertySetCSSStyleDeclaration.h View 3 chunks +0 lines, -36 lines 0 comments Download
M sky/engine/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
M sky/engine/core/css/RuleSet.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/RuleSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + sky/engine/core/css/StyleKeyframe.h View 2 chunks +8 lines, -30 lines 0 comments Download
A + sky/engine/core/css/StyleKeyframe.cpp View 2 chunks +1 line, -32 lines 0 comments Download
M sky/engine/core/css/StylePropertySet.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/StylePropertySet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/StyleRule.h View 3 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/css/StyleRule.cpp View 3 chunks +1 line, -49 lines 0 comments Download
A + sky/engine/core/css/StyleRuleKeyframes.h View 2 chunks +3 lines, -46 lines 0 comments Download
A + sky/engine/core/css/StyleRuleKeyframes.cpp View 2 chunks +31 lines, -42 lines 0 comments Download
M sky/engine/core/css/StyleSheet.h View 3 chunks +1 line, -5 lines 0 comments Download
D sky/engine/core/css/StyleSheet.idl View 1 chunk +0 lines, -30 lines 0 comments Download
M sky/engine/core/css/StyleSheetList.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/css/StyleSheetList.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/core/css/StyleSheetList.idl View 1 chunk +0 lines, -28 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/parser/CSSGrammar.y View 1 chunk +5 lines, -4 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/parser/CSSTokenizer-in.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M sky/engine/core/dom/Document.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/editing/EditingStyle.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLStyleElement.idl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ojan
lgtm \o/
6 years ago (2014-12-03 17:50:41 UTC) #2
esprehn
6 years ago (2014-12-03 18:50:10 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b091f0d20cc0086bff3271aadfe801fef79062ec.

Powered by Google App Engine
This is Rietveld 408576698