Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: sky/engine/core/css/CSSRule.cpp

Issue 780483002: Remove the CSSOM. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/CSSRule.h ('k') | sky/engine/core/css/CSSRule.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/CSSRule.cpp
diff --git a/sky/engine/core/css/CSSRule.cpp b/sky/engine/core/css/CSSRule.cpp
deleted file mode 100644
index f89be130060f1a832e3b19249ff9abed4bc0ae4b..0000000000000000000000000000000000000000
--- a/sky/engine/core/css/CSSRule.cpp
+++ /dev/null
@@ -1,63 +0,0 @@
-/*
- * (C) 1999-2003 Lars Knoll (knoll@kde.org)
- * (C) 2002-2003 Dirk Mueller (mueller@kde.org)
- * Copyright (C) 2002, 2005, 2006, 2007, 2012 Apple Inc. All rights reserved.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB. If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- */
-
-#include "sky/engine/config.h"
-#include "sky/engine/core/css/CSSRule.h"
-
-#include "sky/engine/core/css/CSSStyleSheet.h"
-#include "sky/engine/core/css/StyleRule.h"
-#include "sky/engine/core/css/StyleSheetContents.h"
-#include "sky/engine/platform/NotImplemented.h"
-
-namespace blink {
-
-// VC++ 2013 doesn't support EBCO (Empty Base Class Optimization), and having
-// multiple empty base classes makes the size of CSSRule bloat (Note that both
-// of GarbageCollectedFinalized and ScriptWrappableBase are empty classes).
-// See the following article for details.
-// http://social.msdn.microsoft.com/forums/vstudio/en-US/504c6598-6076-4acf-96b6-e6acb475d302/vc-multiple-inheritance-empty-base-classes-bloats-object-size
-//
-// FIXME: Remove ScriptWrappableBase from the base class list once VC++'s issue
-// gets fixed.
-// Note that we're going to split CSSRule class into two classes; CSSOMRule
-// (assumed name) which derives ScriptWrappable and CSSRule (new one) which
-// doesn't derive ScriptWrappable or ScriptWrappableBase. Then, we can safely
-// remove ScriptWrappableBase from the base class list.
-struct SameSizeAsCSSRule : public RefCounted<SameSizeAsCSSRule>, public ScriptWrappableBase {
- virtual ~SameSizeAsCSSRule();
- unsigned char bitfields;
- void* pointerUnion;
-};
-
-COMPILE_ASSERT(sizeof(CSSRule) == sizeof(SameSizeAsCSSRule), CSSRule_should_stay_small);
-
-void CSSRule::setCSSText(const String&)
-{
- notImplemented();
-}
-
-const CSSParserContext& CSSRule::parserContext() const
-{
- CSSStyleSheet* styleSheet = parentStyleSheet();
- return styleSheet ? styleSheet->contents()->parserContext() : strictCSSParserContext();
-}
-
-} // namespace blink
« no previous file with comments | « sky/engine/core/css/CSSRule.h ('k') | sky/engine/core/css/CSSRule.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698