Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 780393002: clear() is now an alias for drawPaint, so remove its virtual (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

clear() is now an alias for drawPaint, so remove its virtual Needs these to land first: https://codereview.chromium.org/733343005 https://codereview.chromium.org/777413004 BUG=skia: Committed: https://skia.googlesource.com/skia/+/f4e0d9eb2d72fe92c30237de978936113143dc16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M include/core/SkCanvas.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
reed1
6 years ago (2014-12-05 22:05:25 UTC) #2
f(malita)
lgtm
6 years ago (2014-12-05 23:51:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780393002/1
6 years ago (2014-12-06 04:40:20 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-06 04:49:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f4e0d9eb2d72fe92c30237de978936113143dc16

Powered by Google App Engine
This is Rietveld 408576698