Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: include/core/SkCanvas.h

Issue 780393002: clear() is now an alias for drawPaint, so remove its virtual (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkCanvas.h
diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h
index ee539c4244864072ac25be34f06c1b01d2d189f0..ff60c57fa7ec325a7678fbb8e1e28629b83e71a2 100644
--- a/include/core/SkCanvas.h
+++ b/include/core/SkCanvas.h
@@ -621,8 +621,11 @@ public:
*/
void drawColor(SkColor color, SkXfermode::Mode mode = SkXfermode::kSrcOver_Mode);
- // TODO: remove virtual when chrome subclass stop overriding this.
- virtual void clear(SkColor color) {
+ /**
+ * Helper method for drawing a color in SRC mode, completely replacing all the pixels
+ * in the current clip with this color.
+ */
+ void clear(SkColor color) {
this->drawColor(color, SkXfermode::kSrc_Mode);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698