Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6024)

Unified Diff: chrome/browser/io_thread.cc

Issue 780223005: Remove obsolete logic for inferring QUIC behavior from the name of field trial groups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/io_thread_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index 4fa4eb5beec11d254d593e3a68647c2cbf1666a4..73f9f30c76fd0478ab167bc3d5d78f1ac7772f3b 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -124,8 +124,6 @@ const char kTCPFastOpenHttpsEnabledGroupName[] = "HttpsEnabled";
const char kQuicFieldTrialName[] = "QUIC";
const char kQuicFieldTrialEnabledGroupName[] = "Enabled";
const char kQuicFieldTrialHttpsEnabledGroupName[] = "HttpsEnabled";
-const char kQuicFieldTrialPacketLengthSuffix[] = "BytePackets";
-const char kQuicFieldTrialPacingSuffix[] = "WithPacing";
// The SPDY trial composes two different trial plus control groups:
// * A "holdback" group with SPDY disabled, and corresponding control
@@ -1286,12 +1284,9 @@ bool IOThread::ShouldEnableQuicPacing(
if (command_line.HasSwitch(switches::kDisableQuicPacing))
return false;
- if (LowerCaseEqualsASCII(
+ return LowerCaseEqualsASCII(
GetVariationParam(quic_trial_params, "enable_pacing"),
- "true"))
- return true;
-
- return quic_trial_group.ends_with(kQuicFieldTrialPacingSuffix);
+ "true");
}
net::QuicTagVector IOThread::GetQuicConnectionOptions(
@@ -1390,25 +1385,7 @@ size_t IOThread::GetQuicMaxPacketLength(
&value)) {
return value;
}
-
- // Format of the packet length group names is:
- // (Https)?Enabled<length>BytePackets.
- base::StringPiece length_str(quic_trial_group);
- if (length_str.starts_with(kQuicFieldTrialEnabledGroupName)) {
- length_str.remove_prefix(strlen(kQuicFieldTrialEnabledGroupName));
- } else if (length_str.starts_with(kQuicFieldTrialHttpsEnabledGroupName)) {
- length_str.remove_prefix(strlen(kQuicFieldTrialHttpsEnabledGroupName));
- } else {
- return 0;
- }
- if (!length_str.ends_with(kQuicFieldTrialPacketLengthSuffix)) {
- return 0;
- }
- length_str.remove_suffix(strlen(kQuicFieldTrialPacketLengthSuffix));
- if (!base::StringToUint(length_str, &value)) {
- return 0;
- }
- return value;
+ return 0;
}
// static
« no previous file with comments | « no previous file | chrome/browser/io_thread_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698