Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: chrome/browser/io_thread_unittest.cc

Issue 780223005: Remove obsolete logic for inferring QUIC behavior from the name of field trial groups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc b/chrome/browser/io_thread_unittest.cc
index 18c4844de100c6dc8000e35df7a1c1bba824ccb4..e11676a6f81367be8dc6ddf5a0e37417a5c5c2af 100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -156,17 +156,6 @@ TEST_F(IOThreadTest, EnablePacingFromCommandLine) {
EXPECT_EQ(options, params.quic_connection_options);
}
-TEST_F(IOThreadTest, EnablePacingFromFieldTrialGroup) {
- field_trial_group_ = "EnabledWithPacing";
-
- ConfigureQuicGlobals();
- net::HttpNetworkSession::Params params;
- InitializeNetworkSessionParams(&params);
- net::QuicTagVector options;
- options.push_back(net::kPACE);
- EXPECT_EQ(options, params.quic_connection_options);
-}
-
TEST_F(IOThreadTest, EnablePacingFromFieldTrialParams) {
field_trial_group_ = "Enabled";
field_trial_params_["enable_pacing"] = "true";
@@ -181,31 +170,22 @@ TEST_F(IOThreadTest, EnablePacingFromFieldTrialParams) {
TEST_F(IOThreadTest, PacketLengthFromCommandLine) {
command_line_.AppendSwitch("enable-quic");
- command_line_.AppendSwitchASCII("quic-max-packet-length", "1350");
+ command_line_.AppendSwitchASCII("quic-max-packet-length", "1450");
ConfigureQuicGlobals();
net::HttpNetworkSession::Params params;
InitializeNetworkSessionParams(&params);
- EXPECT_EQ(1350u, params.quic_max_packet_length);
-}
-
-TEST_F(IOThreadTest, PacketLengthFromFieldTrialGroup) {
- field_trial_group_ = "Enabled1350BytePackets";
-
- ConfigureQuicGlobals();
- net::HttpNetworkSession::Params params;
- InitializeNetworkSessionParams(&params);
- EXPECT_EQ(1350u, params.quic_max_packet_length);
+ EXPECT_EQ(1450u, params.quic_max_packet_length);
}
TEST_F(IOThreadTest, PacketLengthFromFieldTrialParams) {
field_trial_group_ = "Enabled";
- field_trial_params_["max_packet_length"] = "1350";
+ field_trial_params_["max_packet_length"] = "1450";
ConfigureQuicGlobals();
net::HttpNetworkSession::Params params;
InitializeNetworkSessionParams(&params);
- EXPECT_EQ(1350u, params.quic_max_packet_length);
+ EXPECT_EQ(1450u, params.quic_max_packet_length);
}
TEST_F(IOThreadTest, QuicVersionFromCommandLine) {
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698