Build standalone network service on Android.

Build standalone network service on Android.

This patch adds hooks and build rules that make the
//mojo/services/network target produce a working, standalone network
service on Android (as an android handler app with appropriate shebang).

BUG=437290
R=qsr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/a350cf52d7cb9f8f747168a0713836b56dbd7d8c

[ppi, 2014-12-04 19:04:15]

Patchset #1 (id:1) has been deleted

[ppi, 2014-12-04 19:05:53]

ppi@chromium.org changed reviewers:
+ qsr@chromium.org

[ppi, 2014-12-04 19:06:28]

ptal

[ppi, 2014-12-05 13:37:33]

Switched to android_standalone_library as discussed (will need to wait until
https://codereview.chromium.org/778093004/ lands and rolls).

ptal.

[qsr, 2014-12-05 13:43:42]

https://codereview.chromium.org/780043002/diff/40001/mojo/services/network/BU...
File mojo/services/network/BUILD.gn (right):

https://codereview.chromium.org/780043002/diff/40001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:22: "//mojo/public/c/system:for_shared_library"
Why is this dep needed here? I would expect that it is either needed by the
linux network service, or not at all.

https://codereview.chromium.org/780043002/diff/40001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:90: group("common_deps") {
Could you use source_set instead and put main.cc there.

Also you might want to rename this network_service_sources instead of
common_deps.

[ppi, 2014-12-05 14:49:54]

Thanks, ptal.

https://codereview.chromium.org/780043002/diff/40001/mojo/services/network/BU...
File mojo/services/network/BUILD.gn (right):

https://codereview.chromium.org/780043002/diff/40001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:22: "//mojo/public/c/system:for_shared_library"
On 2014/12/05 13:43:42, qsr wrote:
> Why is this dep needed here? I would expect that it is either needed by the
> linux network service, or not at all.

It *is* needed by both linux and android, it's just that mojo_native_application
now adds it implicitly.

https://codereview.chromium.org/780043002/diff/40001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:90: group("common_deps") {
On 2014/12/05 13:43:42, qsr wrote:
> Could you use source_set instead and put main.cc there.
> 
> Also you might want to rename this network_service_sources instead of
> common_deps.

Done. Once we drop the shell dependency on :lib, we can probably join :lib and
:sources into one source set.

[qsr, 2014-12-05 15:31:16]

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
File mojo/services/network/BUILD.gn (right):

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:10: java_library_path =
"$target_out_dir/java_library.dex.jar"
Could you add a blank line between this and next line. It is kind of hard to
spot the main target otherwise.

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:24: sources = [
sources before deps -> https://code.google.com/p/chromium/wiki/GNStyleGuide

Also, could you run gn format, will sort all of this for you.

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:30: deps = [
Same thing, deps is the last thing there.

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:85: visibility = [ ":*" ]
Do you need to use this because gn will complain if you reference something that
doesn't exist? If not, please just enumerate the 2 targets.

[ppi, 2014-12-05 17:17:43]

ptal

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
File mojo/services/network/BUILD.gn (right):

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:10: java_library_path =
"$target_out_dir/java_library.dex.jar"
On 2014/12/05 15:31:16, qsr wrote:
> Could you add a blank line between this and next line. It is kind of hard to
> spot the main target otherwise.

Done.

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:24: sources = [
On 2014/12/05 15:31:16, qsr wrote:
> sources before deps -> https://code.google.com/p/chromium/wiki/GNStyleGuide
> 
> Also, could you run gn format, will sort all of this for you.

Done.

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:30: deps = [
On 2014/12/05 15:31:16, qsr wrote:
> Same thing, deps is the last thing there.

Done.

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:85: visibility = [ ":*" ]
On 2014/12/05 15:31:16, qsr wrote:
> Do you need to use this because gn will complain if you reference something
that
> doesn't exist? If not, please just enumerate the 2 targets.

ERROR at //mojo/public/mojo_application.gni:30:3: Dependency not allowed.
  shared_library(library_target_name) {
  ^------------------------------------
The item //mojo/services/network:network_service_library
can not depend on //mojo/services/network:sources
because it is not in //mojo/services/network:sources's visibility list: [
  //mojo/services/network:native_library
  //mojo/services/network:network
]
***************

gn complains because (on Linux) it's a generated target that the dependency on
":sources" will be carried to. Naming of this generated target is an impl.
detail of the template, so it feels weird to mention it explicitly here. Wdyt?

[qsr, 2014-12-08 14:27:07]

lgtm

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
File mojo/services/network/BUILD.gn (right):

https://codereview.chromium.org/780043002/diff/60001/mojo/services/network/BU...
mojo/services/network/BUILD.gn:85: visibility = [ ":*" ]
On 2014/12/05 17:17:43, ppi wrote:
> On 2014/12/05 15:31:16, qsr wrote:
> > Do you need to use this because gn will complain if you reference something
> that
> > doesn't exist? If not, please just enumerate the 2 targets.
> 
> ERROR at //mojo/public/mojo_application.gni:30:3: Dependency not allowed.
>   shared_library(library_target_name) {
>   ^------------------------------------
> The item //mojo/services/network:network_service_library
> can not depend on //mojo/services/network:sources
> because it is not in //mojo/services/network:sources's visibility list: [
>   //mojo/services/network:native_library
>   //mojo/services/network:network
> ]
> ***************
> 
> gn complains because (on Linux) it's a generated target that the dependency on
> ":sources" will be carried to. Naming of this generated target is an impl.
> detail of the template, so it feels weird to mention it explicitly here. Wdyt?

 That doesn't feel right. There might be something missing in the
mojo_native_application template so that private target can depend on thing that
the main target can depend on. On the other end, :* is defined in gn help
visibility, so I guess this is OK.

[ppi, 2014-12-10 14:55:21]

Committed patchset #5 (id:100001) manually as
a350cf52d7cb9f8f747168a0713836b56dbd7d8c (presubmit successful).