MacViews: Use RenderTextHarfBuzz only for Textfields

ui/gfx/render_text.h

Index: ui/gfx/render_text.h
diff --git a/ui/gfx/render_text.h b/ui/gfx/render_text.h
index 9dc353ade39964403541e956d9a602c1d338f3ff..d52787d2e8b6d445917e19df470814f463c61840 100644
--- a/ui/gfx/render_text.h
+++ b/ui/gfx/render_text.h
@@ -191,6 +191,10 @@ class GFX_EXPORT RenderText {
 
   // Creates a platform-specific or cross-platform RenderText instance.
   static RenderText* CreateInstance();
+  static RenderText* CreateInstanceForEditing();
+
+  // Creates another instance of the same concrete class.
+  virtual scoped_ptr<RenderText> NewInstance() const = 0;

[msw, 2014/12/08 19:27:50]

nit: CreateInstanceOfSameType?

[Andre, 2014/12/08 19:51:32]

I thought about calling it Clone(), but it doesn't clone the attributes.
How about CreateCloneInstance or CreateInstanceForClone?

[msw, 2014/12/08 19:57:52]

Sure, I slightly prefer CreateInstanceForClone.

 
   const base::string16& text() const { return text_; }
   void SetText(const base::string16& text);