MacViews: Use RenderTextHarfBuzz only for Textfields

ui/gfx/render_text.cc

Index: ui/gfx/render_text.cc
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index add661d64c9d5edc34449ac3b0cf53bc7d102756..caa5c8e5b1a3fb37901a1625aec17d31d9f9989e 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -398,7 +398,7 @@ RenderText::~RenderText() {
 }
 
 RenderText* RenderText::CreateInstance() {
-#if defined(OS_MACOSX) && !defined(TOOLKIT_VIEWS)

[Alexei Svitkine (slow), 2014/12/08 15:53:10]

Is this change needed anymore?

[Andre, 2014/12/08 18:33:45]

I think so.
TOOLKIT_VIEWS will be turned on soon for Mac, and we don't want that change to
affect the Cocoa
browser.

+#if defined(OS_MACOSX)
   static const bool use_harfbuzz = CommandLine::ForCurrentProcess()->
       HasSwitch(switches::kEnableHarfBuzzRenderText);
 #else
@@ -408,6 +408,10 @@ RenderText* RenderText::CreateInstance() {
   return use_harfbuzz ? new RenderTextHarfBuzz : CreateNativeInstance();
 }
 
+RenderText* RenderText::CreateInstanceForEditing() {
+  return new RenderTextHarfBuzz;

[msw, 2014/12/08 19:27:50]

Shouldn't this respect kDisableHarfBuzzRenderText?

[Andre, 2014/12/08 19:51:32]

Done.

+}
+
 void RenderText::SetText(const base::string16& text) {
   DCHECK(!composition_range_.IsValid());
   if (text_ == text)
@@ -1233,7 +1237,7 @@ base::string16 RenderText::Elide(const base::string16& text,
     return ElideEmail(text, available_width);
 
   // Create a RenderText copy with attributes that affect the rendering width.
-  scoped_ptr<RenderText> render_text(CreateInstance());
+  scoped_ptr<RenderText> render_text = NewInstance();
   render_text->SetFontList(font_list_);
   render_text->SetDirectionalityMode(directionality_mode_);
   render_text->SetCursorEnabled(cursor_enabled_);