Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2222)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 779593002: Move elementAccess() from namer to emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 865e32c550aabbe61a668c969b5d8ddab4abc645..aa7a672eb4d33d1742d814233d2941f3fcfdb2dc 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -3759,7 +3759,7 @@ class SsaBuilder extends ResolvedVisitor {
registry.registerStaticUse(element);
push(new HForeign(js.js.expressionTemplateYielding(
- backend.namer.elementAccess(element)),
+ backend.emitter.globalPropertyAccess(element)),
floitsch 2014/12/03 17:02:26 Not 100% sure. I believe it's a staticFunction, bu
zarah 2014/12/05 08:22:51 Yes, Done.
backend.dynamicType,
<HInstruction>[]));
return params;
@@ -3802,7 +3802,8 @@ class SsaBuilder extends ResolvedVisitor {
compiler.internalError(node.argumentsNode, 'Too many arguments.');
}
push(new HForeign(js.js.expressionTemplateYielding(
- backend.namer.elementAccess(compiler.objectClass)),
+ backend.emitter.globalPropertyAccess(
floitsch 2014/12/03 17:02:26 jsConstructorAccess
zarah 2014/12/05 08:22:51 Done.
+ compiler.objectClass)),
backend.dynamicType,
<HInstruction>[]));
}

Powered by Google App Engine
This is Rietveld 408576698