Move elementAccess() from namer to emitter.

pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart

Index: pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart
diff --git a/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart b/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart
index 6007dba7b9e1a965b0dd5aedf0342985f113d646..73c317b23dc525db0c04d478c060cb4b91a7f10b 100644
--- a/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart
+++ b/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart
@@ -13,7 +13,7 @@ class InterceptorStubGenerator {
 
   jsAst.Expression generateGetInterceptorMethod(Set<ClassElement> classes) {
     jsAst.Expression interceptorFor(ClassElement cls) {
-      return js('#.prototype', namer.elementAccess(cls));
+      return js('#.prototype', backend.emitter.globalPropertyAccess(cls));

[floitsch, 2014/12/03 17:02:25]

classAccess
Maybe even classPrototypeAccess

Interestingly we needed to add "eager" classes because of the interceptors.
If we change the way we access classPrototypes we could potentially remove the
eager classes again.

[zarah, 2014/12/05 08:22:50]

Done.

     }
 
     /**
@@ -142,8 +142,8 @@ class InterceptorStubGenerator {
           if (receiver instanceof #) return receiver;
           return #(receiver);
       }''', [
-          namer.elementAccess(compiler.objectClass),
-          namer.elementAccess(backend.getNativeInterceptorMethod)]));
+          backend.emitter.globalPropertyAccess(compiler.objectClass),

[floitsch, 2014/12/03 17:02:25]

either classAccess or constructorAccess.
Both make sense:
- classAccess, because we make an is-check.
- constructorAccess, because that's what we have to use in JS to do an is-check.

Almost leaning towards constructorAccess.
Also: should probably be jsConstructorAccess.

[zarah, 2014/12/05 08:22:50]

Done.

+          backend.emitter.globalPropertyAccess(backend.getNativeInterceptorMethod)]));

[floitsch, 2014/12/03 17:02:25]

staticFunctionAccess.

Long line.

[zarah, 2014/12/05 08:22:50]

Done.

 
     } else {
       ClassElement jsUnknown = backend.jsUnknownJavaScriptObjectClass;
@@ -151,7 +151,7 @@ class InterceptorStubGenerator {
               .directlyInstantiatedClasses.contains(jsUnknown)) {
         statements.add(
             js.statement('if (!(receiver instanceof #)) return #;',
-                [namer.elementAccess(compiler.objectClass),
+                [backend.emitter.globalPropertyAccess(compiler.objectClass),

[floitsch, 2014/12/03 17:02:25]

as in line 145.

[zarah, 2014/12/05 08:22:51]

Done.

                  interceptorFor(jsUnknown)]));
       }