Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: pkg/compiler/lib/src/js_backend/runtime_types.dart

Issue 779593002: Move elementAccess() from namer to emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/runtime_types.dart
diff --git a/pkg/compiler/lib/src/js_backend/runtime_types.dart b/pkg/compiler/lib/src/js_backend/runtime_types.dart
index d834eac6b27dde855ea61db7f0dcc95a77c57e1b..87f5046a6ba2cdcd51bd4122abba5002c78c9b1d 100644
--- a/pkg/compiler/lib/src/js_backend/runtime_types.dart
+++ b/pkg/compiler/lib/src/js_backend/runtime_types.dart
@@ -539,7 +539,7 @@ class RuntimeTypes {
JavaScriptBackend backend = compiler.backend;
String contextName = backend.namer.getNameOfClass(contextClass);
return js('function () { return #(#, #, #); }',
- [ backend.namer.elementAccess(backend.getComputeSignature()),
+ [ backend.emitter.globalPropertyAccess(backend.getComputeSignature()),
floitsch 2014/12/03 17:02:25 I'm guessing staticFunctionAccess
zarah 2014/12/05 08:22:50 Yes, Done.
encoding, this_, js.string(contextName) ]);
} else {
return encoding;
@@ -631,7 +631,7 @@ class TypeRepresentationGenerator extends DartTypeVisitor {
}
jsAst.Expression getJavaScriptClassName(Element element) {
- return namer.elementAccess(element);
+ return backend.emitter.globalPropertyAccess(element);
floitsch 2014/12/03 17:02:25 I'm not sure what the element is here, and how it
zarah 2014/12/05 08:22:50 classAccess and typedefAccess
}
visit(DartType type) {

Powered by Google App Engine
This is Rietveld 408576698