Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 779383004: Add presubmit to ensure GN formatting (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, brettw, tfarina, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add presubmit to ensure GN formatting Check added here: https://codereview.chromium.org/779513005/ R=phajdan.jr@chromium.org BUG=348474 Committed: https://crrev.com/39b29956b7f12965a8ab49bbe4ee9cc1c8503b0c Cr-Commit-Position: refs/heads/master@{#307282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
scottmg
6 years ago (2014-12-06 01:14:17 UTC) #3
Paweł Hajdan Jr.
LGTM
6 years ago (2014-12-08 10:13:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779383004/1
6 years ago (2014-12-08 17:45:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 18:31:34 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-08 18:32:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39b29956b7f12965a8ab49bbe4ee9cc1c8503b0c
Cr-Commit-Position: refs/heads/master@{#307282}

Powered by Google App Engine
This is Rietveld 408576698