PRESUBMIT.py - Issue 779383004: Add presubmit to ensure GN formatting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 779383004: Add presubmit to ensure GN formatting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index e141c6bcdc8769d2849774f7a410184ddf29504a..9e26bebf7d3167110514a2c5ac49f46eaed233c0 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -1568,6 +1568,8 @@ def CheckChangeOnUpload(input_api, output_api):

results.extend(_CheckValidHostsInDEPS(input_api, output_api))

results.extend(_CheckJavaStyle(input_api, output_api))

results.extend(_CheckUmaHistogramChanges(input_api, output_api))

+ results.extend(

+ input_api.canned_checks.CheckGNFormatted(input_api, output_api))

return results

« no previous file with comments | « no previous file | no next file » | no next file with comments »