Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: tools/telemetry/telemetry/page/page_test_unittest.py

Issue 779383002: Move WPR-related attributes to UserStorySet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_test_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_test_unittest.py b/tools/telemetry/telemetry/page/page_test_unittest.py
index aac88fd7a968e77fa43804d9150a122eecc40afa..0654d791e6d0b79f7aabb88fea03e4aa85b8edf2 100644
--- a/tools/telemetry/telemetry/page/page_test_unittest.py
+++ b/tools/telemetry/telemetry/page/page_test_unittest.py
@@ -108,7 +108,8 @@ class PageTestUnitTest(page_test_test_case.PageTestTestCase):
# First record an archive with only www.google.com.
self._options.browser_options.wpr_mode = wpr_modes.WPR_RECORD
- ps.wpr_archive_info = page_set_archive_info.PageSetArchiveInfo(
+ # pylint: disable=protected-access
+ ps._wpr_archive_info = page_set_archive_info.PageSetArchiveInfo(
'', '', ps.bucket, json.loads(archive_info_template %
(test_archive, google_url)))
ps.pages = [page_module.Page(google_url, ps)]
@@ -118,14 +119,16 @@ class PageTestUnitTest(page_test_test_case.PageTestTestCase):
# Now replay it and verify that google.com is found but foo.com is not.
self._options.browser_options.wpr_mode = wpr_modes.WPR_REPLAY
- ps.wpr_archive_info = page_set_archive_info.PageSetArchiveInfo(
+ # pylint: disable=protected-access
+ ps._wpr_archive_info = page_set_archive_info.PageSetArchiveInfo(
'', '', ps.bucket, json.loads(archive_info_template %
(test_archive, foo_url)))
ps.pages = [page_module.Page(foo_url, ps)]
all_results = self.RunMeasurement(measurement, ps, options=self._options)
self.assertEquals(1, len(all_results.failures))
- ps.wpr_archive_info = page_set_archive_info.PageSetArchiveInfo(
+ # pylint: disable=protected-access
+ ps._wpr_archive_info = page_set_archive_info.PageSetArchiveInfo(
'', '', ps.bucket, json.loads(archive_info_template %
(test_archive, google_url)))
ps.pages = [page_module.Page(google_url, ps)]
« no previous file with comments | « tools/telemetry/telemetry/page/page_set_unittest.py ('k') | tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698