Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: tools/telemetry/telemetry/page/page_set_unittest.py

Issue 779383002: Move WPR-related attributes to UserStorySet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_set_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_set_unittest.py b/tools/telemetry/telemetry/page/page_set_unittest.py
index 6f781217421ca987e7cdcfdd09016bf5af465ef4..84ad14074c54de2d84160c9639128739401f4d36 100644
--- a/tools/telemetry/telemetry/page/page_set_unittest.py
+++ b/tools/telemetry/telemetry/page/page_set_unittest.py
@@ -42,25 +42,6 @@ class TestPageSet(unittest.TestCase):
finally:
os.rmdir(directory_path)
- def testCloudBucket(self):
- blank_ps = page_set.PageSet()
- expected_bucket = None
- self.assertEqual(blank_ps.bucket, expected_bucket)
-
- public_ps = page_set.PageSet(bucket=page_set.PUBLIC_BUCKET)
- expected_bucket = cloud_storage.PUBLIC_BUCKET
- self.assertEqual(public_ps.bucket, expected_bucket)
-
- partner_ps = page_set.PageSet(bucket=page_set.PARTNER_BUCKET)
- expected_bucket = cloud_storage.PARTNER_BUCKET
- self.assertEqual(partner_ps.bucket, expected_bucket)
-
- internal_ps = page_set.PageSet(bucket=page_set.INTERNAL_BUCKET)
- expected_bucket = cloud_storage.INTERNAL_BUCKET
- self.assertEqual(internal_ps.bucket, expected_bucket)
-
- self.assertRaises(ValueError, page_set.PageSet, bucket='garbage_bucket')
-
def testFormingPageSetFromSubPageSet(self):
page_set_a = page_set.PageSet()
pages = [
« no previous file with comments | « tools/telemetry/telemetry/page/page_set_archive_info_unittest.py ('k') | tools/telemetry/telemetry/page/page_test_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698