Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 779193003: Add presubmit for gn formatting (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
jamesr, eseidel
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add presubmit for gn formatting If you want. I'll probably add it to chrome next week sometime. (Includes buildtools roll for gn binary.) R=jamesr@chromium.org,eseidel@chromium.org BUG=348474

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : to upload, not always #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
6 years ago (2014-12-06 00:35:00 UTC) #1
jamesr
We normally keep the DEPS hashes completely in sync with chrome's, so if we take ...
6 years ago (2014-12-06 00:54:46 UTC) #2
scottmg
OK, it just rolled into chrome. I don't want to do the full roll in ...
6 years ago (2014-12-06 00:57:41 UTC) #3
jamesr
OK cool. I'll do a roll then land the PRESUBMIT.py change from here. *normally* the ...
6 years ago (2014-12-06 00:59:39 UTC) #4
jamesr
Landed (w/ roll) at https://chromium.googlesource.com/external/mojo/+/d2015d9f67dc968437fd3dc578dc3e8d4104dcdf
6 years ago (2014-12-08 22:13:49 UTC) #5
scottmg
6 years ago (2014-12-08 22:14:53 UTC) #6
Message was sent while issue was closed.
On 2014/12/08 22:13:49, jamesr wrote:
> Landed (w/ roll) at
>
https://chromium.googlesource.com/external/mojo/+/d2015d9f67dc968437fd3dc578d...

Thanks!

(It's on in chromium now too.)

Powered by Google App Engine
This is Rietveld 408576698