Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Side by Side Diff: PRESUBMIT.py

Issue 779193003: Add presubmit for gn formatting (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: to upload, not always Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1524 matching lines...) Expand 10 before | Expand all | Expand 10 after
1535 ('%s:%d uses mojo:// url format. Please use mojo: instead.') 1535 ('%s:%d uses mojo:// url format. Please use mojo: instead.')
1536 % (f.LocalPath(), lnum))) 1536 % (f.LocalPath(), lnum)))
1537 return errors 1537 return errors
1538 1538
1539 1539
1540 def CheckChangeOnUpload(input_api, output_api): 1540 def CheckChangeOnUpload(input_api, output_api):
1541 results = [] 1541 results = []
1542 results.extend(_CommonChecks(input_api, output_api)) 1542 results.extend(_CommonChecks(input_api, output_api))
1543 results.extend(_CheckValidHostsInDEPS(input_api, output_api)) 1543 results.extend(_CheckValidHostsInDEPS(input_api, output_api))
1544 results.extend(_CheckJavaStyle(input_api, output_api)) 1544 results.extend(_CheckJavaStyle(input_api, output_api))
1545 results.extend(
1546 input_api.canned_checks.CheckGNFormatted(input_api, output_api))
1545 return results 1547 return results
1546 1548
1547 1549
1548 def GetDefaultTryConfigs(bots=None): 1550 def GetDefaultTryConfigs(bots=None):
1549 """Returns a list of ('bot', set(['tests']), optionally filtered by [bots]. 1551 """Returns a list of ('bot', set(['tests']), optionally filtered by [bots].
1550 1552
1551 If 'bots' is specified, will only return configurations for bots in that list. 1553 If 'bots' is specified, will only return configurations for bots in that list.
1552 """ 1554 """
1553 1555
1554 builders_and_tests = { 1556 builders_and_tests = {
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
1595 builders = [ 1597 builders = [
1596 'Mojo Linux Try', 1598 'Mojo Linux Try',
1597 'Mojo Linux (dbg) Try', 1599 'Mojo Linux (dbg) Try',
1598 'Mojo Android Builder Try', 1600 'Mojo Android Builder Try',
1599 'Mojo Android Builder (dbg) Try', 1601 'Mojo Android Builder (dbg) Try',
1600 'Mojo ChromeOS Builder Try', 1602 'Mojo ChromeOS Builder Try',
1601 'Mojo ChromeOS Builder (dbg) Try', 1603 'Mojo ChromeOS Builder (dbg) Try',
1602 ] 1604 ]
1603 1605
1604 return GetDefaultTryConfigs(builders) 1606 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698