Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 779183004: Get rid of the PaintLayerFlags bitmask. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Get rid of the PaintLayerFlags bitmask. Make it a regular enum and remove it from all the functions it's not actually used. Also, make paintLayer and PaintLayerFlags private since they're only used in RenderLayer. R=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/96031b14cb8b634b238f35f5ddad4cf8b9f735ee

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -50 lines) Patch
M sky/engine/core/rendering/LayerPaintingInfo.h View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 6 chunks +18 lines, -13 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 18 chunks +30 lines, -30 lines 2 comments Download

Messages

Total messages: 5 (2 generated)
ojan
https://codereview.chromium.org/779183004/diff/1/sky/engine/core/rendering/RenderLayer.cpp File sky/engine/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/779183004/diff/1/sky/engine/core/rendering/RenderLayer.cpp#newcode1051 sky/engine/core/rendering/RenderLayer.cpp:1051: bool isPaintingOverlayScrollbars = paintFlags == PaintOverlayScrollbars; This is the ...
6 years ago (2014-12-06 03:47:42 UTC) #2
eseidel1
lgtm
6 years ago (2014-12-08 17:10:33 UTC) #4
ojan
6 years ago (2014-12-08 17:21:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96031b14cb8b634b238f35f5ddad4cf8b9f735ee.

Powered by Google App Engine
This is Rietveld 408576698