Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: sky/engine/core/rendering/LayerPaintingInfo.h

Issue 779183004: Get rid of the PaintLayerFlags bitmask. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 #ifndef SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_ 45 #ifndef SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_
46 #define SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_ 46 #define SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_
47 47
48 #include "sky/engine/core/rendering/PaintInfo.h" 48 #include "sky/engine/core/rendering/PaintInfo.h"
49 #include "sky/engine/platform/geometry/LayoutRect.h" 49 #include "sky/engine/platform/geometry/LayoutRect.h"
50 50
51 namespace blink { 51 namespace blink {
52 52
53 class RenderLayer; 53 class RenderLayer;
54 54
55 // FIXME(sky): Get rid of this bitmasking and just use a regular enum.
56 enum PaintLayerFlag {
57 PaintLayerPaintingOverlayScrollbars = 1,
58 };
59
60 typedef unsigned PaintLayerFlags;
61
62 struct LayerPaintingInfo { 55 struct LayerPaintingInfo {
63 LayerPaintingInfo(RenderLayer* inRootLayer, const LayoutRect& inDirtyRect, 56 LayerPaintingInfo(RenderLayer* inRootLayer, const LayoutRect& inDirtyRect,
64 PaintBehavior inPaintBehavior, const LayoutSize& inSubPixelAccumulation, 57 PaintBehavior inPaintBehavior, const LayoutSize& inSubPixelAccumulation,
65 RenderObject* inPaintingRoot = 0) 58 RenderObject* inPaintingRoot = 0)
66 : rootLayer(inRootLayer) 59 : rootLayer(inRootLayer)
67 , paintingRoot(inPaintingRoot) 60 , paintingRoot(inPaintingRoot)
68 , paintDirtyRect(inDirtyRect) 61 , paintDirtyRect(inDirtyRect)
69 , subPixelAccumulation(inSubPixelAccumulation) 62 , subPixelAccumulation(inSubPixelAccumulation)
70 , paintBehavior(inPaintBehavior) 63 , paintBehavior(inPaintBehavior)
71 , clipToDirtyRect(true) 64 , clipToDirtyRect(true)
72 { } 65 { }
73 RenderLayer* rootLayer; 66 RenderLayer* rootLayer;
74 RenderObject* paintingRoot; // only paint descendants of this object 67 RenderObject* paintingRoot; // only paint descendants of this object
75 LayoutRect paintDirtyRect; // relative to rootLayer; 68 LayoutRect paintDirtyRect; // relative to rootLayer;
76 LayoutSize subPixelAccumulation; 69 LayoutSize subPixelAccumulation;
77 PaintBehavior paintBehavior; 70 PaintBehavior paintBehavior;
78 bool clipToDirtyRect; 71 bool clipToDirtyRect;
79 }; 72 };
80 73
81 } // namespace blink 74 } // namespace blink
82 75
83 #endif // SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_ 76 #endif // SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_
OLDNEW
« no previous file with comments | « no previous file | sky/engine/core/rendering/RenderLayer.h » ('j') | sky/engine/core/rendering/RenderLayer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698