Remove all but one of the PaintLayerFlags.

Remove all but one of the PaintLayerFlags.

Only PaintLayerPaintingOverlayScrollbars is actually ever set
to a different value in different codepaths.

-PaintLayerHaveTransparency can just be replaced with
isTransparent() calls.
-PaintLayerPaintingCompositingScrollingPhase is unused.
-PaintLayerPaintingCompositingAllPhases is always set,
which means that the other three compositing ones are
also always set.

The third bullet more clearly falls out when you see that
the only caller of paintLayerContents is
paintLayerContentsAndReflection, which sets
PaintLayerPaintingCompositingAllPhases on the paint flags.
Get rid of paintLayerContentsAndReflection since we no
longer have reflections.

The rest of the changes are all just propagating the now
always false or true booleans in paintLayerContents.

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/1d91759c42b2a0b511c08faa687686956e5c320f

[ojan, 2014-12-04 03:47:14]

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/La...
File sky/engine/core/rendering/LayerPaintingInfo.h (right):

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/La...
sky/engine/core/rendering/LayerPaintingInfo.h:55: // FIXME(sky): Get rid of this
bitmasking and just use a regular enum.
Will remove the enum in a followup to try to keep this patch manageable to
review.

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/La...
sky/engine/core/rendering/LayerPaintingInfo.h:55: // FIXME(sky): Get rid of this
bitmasking and just use a regular enum.
Will remove the enum in a followup to try to keep this patch manageable to
review.

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderLayer.cpp (left):

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1015: bool haveTransparency =
paintFlags & PaintLayerHaveTransparency;
Moved down to where it's first used and called isTransparent instead of using
the paint flag since that's all the caller did anyways.

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1017: bool isPaintingOverlayScrollbars
= paintFlags & PaintLayerPaintingOverlayScrollbars;
This just moved down to where it's first used.

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1018: bool isPaintingScrollingContent
= paintFlags & PaintLayerPaintingCompositingScrollingPhase;
Always false

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1019: bool
isPaintingCompositedForeground = paintFlags &
PaintLayerPaintingCompositingForegroundPhase;
Always true

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1020: bool
isPaintingCompositedBackground = paintFlags &
PaintLayerPaintingCompositingBackgroundPhase;
Always true

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1030: bool shouldPaintContent =
isSelfPaintingLayer && !isPaintingOverlayScrollbars;
This just moved down to where it's first used.

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1075: if (shouldPaintContent ||
shouldPaintOutline || isPaintingOverlayScrollbars) {
shouldPaintOutline is always true because of !isPaintingScrollingContent &&
isPaintingCompositedForeground.

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1141: bool shouldPaintBackground =
isPaintingCompositedBackground && shouldPaintContent;
This is now just shouldPaintContent.

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1142: bool shouldPaintNegZOrderList =
!isPaintingScrollingContent && isPaintingCompositedBackground;
This is always true.

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1143: bool shouldPaintOwnContents =
isPaintingCompositedForeground && shouldPaintContent;
This is now just shouldPaintContent.

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1144: bool
shouldPaintNormalFlowAndPosZOrderLists = isPaintingCompositedForeground;
This is always true.

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1145: bool
shouldPaintOverlayScrollbars = isPaintingOverlayScrollbars;
Useless local variable. Inlined.

https://codereview.chromium.org/778883002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLayer.cpp:1146: bool shouldPaintMask =
(paintFlags & PaintLayerPaintingCompositingMaskPhase) && shouldPaintContent &&
renderer()->hasMask();
This is now shouldPaintContent && renderer()->hasMask(), but having the local
variable didn't actually add value. So inlined.

[eseidel, 2014-12-04 18:35:09]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2014-12-04 18:35:09]

The CQ bit was checked by eseidel@chromium.org

[eseidel, 2014-12-04 18:35:10]

lgtm

[commit-bot: I haz the power, 2014-12-04 18:38:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-04 18:38:51]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[ojan, 2014-12-04 20:12:10]

Committed patchset #1 (id:1) manually as
1d91759c42b2a0b511c08faa687686956e5c320f.