Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Side by Side Diff: sky/engine/core/rendering/LayerPaintingInfo.h

Issue 778883002: Remove all but one of the PaintLayerFlags. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 #ifndef SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_ 45 #ifndef SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_
46 #define SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_ 46 #define SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_
47 47
48 #include "sky/engine/core/rendering/PaintInfo.h" 48 #include "sky/engine/core/rendering/PaintInfo.h"
49 #include "sky/engine/platform/geometry/LayoutRect.h" 49 #include "sky/engine/platform/geometry/LayoutRect.h"
50 50
51 namespace blink { 51 namespace blink {
52 52
53 class RenderLayer; 53 class RenderLayer;
54 54
55 // FIXME(sky): Get rid of this bitmasking and just use a regular enum.
ojan 2014/12/04 03:47:13 Will remove the enum in a followup to try to keep
ojan 2014/12/04 03:47:13 Will remove the enum in a followup to try to keep
55 enum PaintLayerFlag { 56 enum PaintLayerFlag {
56 PaintLayerHaveTransparency = 1, 57 PaintLayerPaintingOverlayScrollbars = 1,
57 // FIXME(sky): This is unused. Remove it.
58 PaintLayerUncachedClipRects = 1 << 2,
59 PaintLayerPaintingOverlayScrollbars = 1 << 4,
60 PaintLayerPaintingCompositingBackgroundPhase = 1 << 5,
61 PaintLayerPaintingCompositingForegroundPhase = 1 << 6,
62 PaintLayerPaintingCompositingMaskPhase = 1 << 7,
63 PaintLayerPaintingCompositingScrollingPhase = 1 << 8,
64 PaintLayerPaintingCompositingAllPhases = (PaintLayerPaintingCompositingBackg roundPhase | PaintLayerPaintingCompositingForegroundPhase | PaintLayerPaintingCo mpositingMaskPhase)
65 }; 58 };
66 59
67 typedef unsigned PaintLayerFlags; 60 typedef unsigned PaintLayerFlags;
68 61
69 struct LayerPaintingInfo { 62 struct LayerPaintingInfo {
70 LayerPaintingInfo(RenderLayer* inRootLayer, const LayoutRect& inDirtyRect, 63 LayerPaintingInfo(RenderLayer* inRootLayer, const LayoutRect& inDirtyRect,
71 PaintBehavior inPaintBehavior, const LayoutSize& inSubPixelAccumulation, 64 PaintBehavior inPaintBehavior, const LayoutSize& inSubPixelAccumulation,
72 RenderObject* inPaintingRoot = 0) 65 RenderObject* inPaintingRoot = 0)
73 : rootLayer(inRootLayer) 66 : rootLayer(inRootLayer)
74 , paintingRoot(inPaintingRoot) 67 , paintingRoot(inPaintingRoot)
75 , paintDirtyRect(inDirtyRect) 68 , paintDirtyRect(inDirtyRect)
76 , subPixelAccumulation(inSubPixelAccumulation) 69 , subPixelAccumulation(inSubPixelAccumulation)
77 , paintBehavior(inPaintBehavior) 70 , paintBehavior(inPaintBehavior)
78 , clipToDirtyRect(true) 71 , clipToDirtyRect(true)
79 { } 72 { }
80 RenderLayer* rootLayer; 73 RenderLayer* rootLayer;
81 RenderObject* paintingRoot; // only paint descendants of this object 74 RenderObject* paintingRoot; // only paint descendants of this object
82 LayoutRect paintDirtyRect; // relative to rootLayer; 75 LayoutRect paintDirtyRect; // relative to rootLayer;
83 LayoutSize subPixelAccumulation; 76 LayoutSize subPixelAccumulation;
84 PaintBehavior paintBehavior; 77 PaintBehavior paintBehavior;
85 bool clipToDirtyRect; 78 bool clipToDirtyRect;
86 }; 79 };
87 80
88 } // namespace blink 81 } // namespace blink
89 82
90 #endif // SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_ 83 #endif // SKY_ENGINE_CORE_RENDERING_LAYERPAINTINGINFO_H_
OLDNEW
« no previous file with comments | « no previous file | sky/engine/core/rendering/RenderLayer.h » ('j') | sky/engine/core/rendering/RenderLayer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698