Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 778833003: Backport WebKit patch to fix input button paddings (Closed)

Created:
6 years ago by Jiang Jiang
Modified:
6 years ago
Reviewers:
Nico
CC:
blink-reviews, Robert Sesek
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Backport WebKit patch to fix input button paddings It's a backport of the following patch by zalan@apple.com: http://trac.webkit.org/changeset/162803 Subpixel Layout: Align <input type="button", submit> etc (PushButtonPart) top and bottom paddings with <button> https://bugs.webkit.org/show_bug.cgi?id=127640 Reviewed by Simon Fraser. <button> sets padding-top: 2px and padding-bottom: 3px as default values (html.css), while <input type="button" (submit, etc) has the hardcoded values of 0, 0 and we center the text using the available space. This results in different baseline text position in normal cases. This adjustment puts the <input type='button' rendering back to the pre-subpixel layout state. BUG=143304 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186630

Patch Set 1 #

Patch Set 2 : Update TestExpectations #

Patch Set 3 : Rebase #

Patch Set 4 : Tweak TestExpectations more #

Patch Set 5 : Rebase #

Patch Set 6 : Add one last TestExpectation #

Patch Set 7 : Update issue id #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 3 chunks +92 lines, -2 lines 0 comments Download
M Source/platform/mac/ThemeMac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Jiang Jiang
Robert, do you by any chance know who might want to take a look at ...
6 years ago (2014-12-05 16:43:54 UTC) #1
Robert Sesek
I've asked tkent@ or thakis@ to review my Mac theme-related patches in the past.
6 years ago (2014-12-05 17:01:28 UTC) #2
Jiang Jiang
Nico, do you want to take a look?
6 years ago (2014-12-05 19:05:44 UTC) #4
Nico
lgtm!
6 years ago (2014-12-05 19:33:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778833003/120001
6 years ago (2014-12-05 22:01:45 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-05 23:39:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186630

Powered by Google App Engine
This is Rietveld 408576698