Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: Source/platform/mac/ThemeMac.mm

Issue 778833003: Backport WebKit patch to fix input button paddings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update issue id Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2010, 2011, 2012 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2010, 2011, 2012 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 641 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 LengthBox ThemeMac::controlPadding(ControlPart part, const FontDescription& font Description, const LengthBox& zoomedBox, float zoomFactor) const 652 LengthBox ThemeMac::controlPadding(ControlPart part, const FontDescription& font Description, const LengthBox& zoomedBox, float zoomFactor) const
653 { 653 {
654 switch (part) { 654 switch (part) {
655 case PushButtonPart: { 655 case PushButtonPart: {
656 // Just use 8px. AppKit wants to use 11px for mini buttons, but tha t padding is just too large 656 // Just use 8px. AppKit wants to use 11px for mini buttons, but tha t padding is just too large
657 // for real-world Web sites (creating a huge necessary minimum width for buttons whose space is 657 // for real-world Web sites (creating a huge necessary minimum width for buttons whose space is
658 // by definition constrained, since we select mini only for small cr amped environments. 658 // by definition constrained, since we select mini only for small cr amped environments.
659 // This also guarantees the HTML <button> will match our rendering b y default, since we're using a consistent 659 // This also guarantees the HTML <button> will match our rendering b y default, since we're using a consistent
660 // padding. 660 // padding.
661 const int padding = 8 * zoomFactor; 661 const int padding = 8 * zoomFactor;
662 return LengthBox(0, padding, 0, padding); 662 return LengthBox(2, padding, 3, padding);
663 } 663 }
664 default: 664 default:
665 return Theme::controlPadding(part, fontDescription, zoomedBox, zoomF actor); 665 return Theme::controlPadding(part, fontDescription, zoomedBox, zoomF actor);
666 } 666 }
667 } 667 }
668 668
669 void ThemeMac::inflateControlPaintRect(ControlPart part, ControlStates states, I ntRect& zoomedRect, float zoomFactor) const 669 void ThemeMac::inflateControlPaintRect(ControlPart part, ControlStates states, I ntRect& zoomedRect, float zoomFactor) const
670 { 670 {
671 BEGIN_BLOCK_OBJC_EXCEPTIONS 671 BEGIN_BLOCK_OBJC_EXCEPTIONS
672 switch (part) { 672 switch (part) {
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
737 break; 737 break;
738 case InnerSpinButtonPart: 738 case InnerSpinButtonPart:
739 paintStepper(states, context, zoomedRect, zoomFactor, scrollableArea ); 739 paintStepper(states, context, zoomedRect, zoomFactor, scrollableArea );
740 break; 740 break;
741 default: 741 default:
742 break; 742 break;
743 } 743 }
744 } 744 }
745 745
746 } 746 }
OLDNEW
« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698