Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 778783002: Use texture size to determine precision of texture coord varyings (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
Reviewers:
joshualitt, jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@defaultp
Visibility:
Public.

Description

Use texture size to determine precision of texture coord varyings. Committed: https://skia.googlesource.com/skia/+/17168df7798d0d12684f18df0556dc19e65b32e6

Patch Set 1 : working #

Patch Set 2 : more #

Total comments: 4

Patch Set 3 : Address comments #

Patch Set 4 : Fix onGetFlags override: #

Patch Set 5 : Add suppressions #

Patch Set 6 : rebase to tot to land #

Patch Set 7 : fix stupid warning #

Patch Set 8 : include skrandom.h in new gm cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -57 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A gm/tallstretchedbitmaps.cpp View 1 2 3 4 5 6 7 1 chunk +112 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 2 3 5 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrCoordTransform.h View 4 chunks +37 lines, -21 lines 0 comments Download
M include/gpu/GrShaderVar.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/gpu/GrTypes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 chunk +9 lines, -0 lines 0 comments Download
A src/gpu/GrCoordTransform.cpp View 1 chunk +61 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 4 chunks +49 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 1 2 4 chunks +58 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 chunks +72 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 2 3 4 5 6 3 chunks +32 lines, -21 lines 0 comments Download
M src/gpu/gl/GrGLUtil.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 2 chunks +3 lines, -9 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 27 (16 generated)
bsalomon
6 years ago (2014-12-08 17:45:17 UTC) #10
joshualitt
lgtm with some nits https://codereview.chromium.org/778783002/diff/180001/src/gpu/GrDrawTargetCaps.h File src/gpu/GrDrawTargetCaps.h (right): https://codereview.chromium.org/778783002/diff/180001/src/gpu/GrDrawTargetCaps.h#newcode54 src/gpu/GrDrawTargetCaps.h:54: */ wraps https://codereview.chromium.org/778783002/diff/180001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp ...
6 years ago (2014-12-08 19:38:32 UTC) #11
bsalomon
https://codereview.chromium.org/778783002/diff/180001/src/gpu/GrDrawTargetCaps.h File src/gpu/GrDrawTargetCaps.h (right): https://codereview.chromium.org/778783002/diff/180001/src/gpu/GrDrawTargetCaps.h#newcode54 src/gpu/GrDrawTargetCaps.h:54: */ On 2014/12/08 19:38:32, joshualitt wrote: > wraps Done. ...
6 years ago (2014-12-08 19:49:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778783002/240001
6 years ago (2014-12-09 16:34:38 UTC) #14
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running git apply --index -3 -p1; error: patch ...
6 years ago (2014-12-09 16:34:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778783002/260001
6 years ago (2014-12-09 16:39:37 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1037)
6 years ago (2014-12-09 16:41:39 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778783002/280001
6 years ago (2014-12-09 16:47:38 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/1097) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1062)
6 years ago (2014-12-09 16:50:09 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778783002/300001
6 years ago (2014-12-09 16:51:48 UTC) #26
commit-bot: I haz the power
6 years ago (2014-12-09 17:00:53 UTC) #27
Message was sent while issue was closed. 
Committed patchset #8 (id:300001) as
https://skia.googlesource.com/skia/+/17168df7798d0d12684f18df0556dc19e65b32e6

Powered by Google App Engine
This is Rietveld 408576698