Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issue 778693004: Reland: Change to Shill's IPConfig objects. (Closed)

Created:
6 years ago by stevenjb
Modified:
6 years ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland: Change to Shill's IPConfig objects. Before a recent Shill change, Static and Saved IP config properties were stored in toplevel properties with prefixed keys like kStaticIPAddressProperty. This change makes use of Shill now exposing these properties nested under a StaticIPConfig and SavedIPConfig dictionary. This also makes the translation between a list of nameservers and a comma-separated string obsolete. Original Review URL: https://codereview.chromium.org/762243002 BUG=411289 TBR=pneubeck@chromium.org Committed: https://crrev.com/870dfbecc375b1e0d89594e1f7de5fa7a4e1ea84 Cr-Commit-Position: refs/heads/master@{#306669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -80 lines) Patch
M chromeos/network/onc/onc_translation_tables.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 3 chunks +15 lines, -18 lines 0 comments Download
M chromeos/network/onc/onc_translator_onc_to_shill.cc View 4 chunks +0 lines, -28 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 4 chunks +18 lines, -22 lines 0 comments Download
M chromeos/test/data/network/shill_ethernet.json View 1 chunk +6 lines, -4 lines 0 comments Download
M chromeos/test/data/network/shill_ethernet_with_ipconfig.json View 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778693004/1
6 years ago (2014-12-03 19:57:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-03 20:44:33 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-03 20:46:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/870dfbecc375b1e0d89594e1f7de5fa7a4e1ea84
Cr-Commit-Position: refs/heads/master@{#306669}

Powered by Google App Engine
This is Rietveld 408576698