Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 762243002: Change to Shill's IPConfig objects. (Closed)

Created:
6 years ago by pneubeck (no reviews)
Modified:
6 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change to Shill's IPConfig objects. Before a recent Shill change, Static and Saved IP config properties were stored in toplevel properties with prefixed keys like kStaticIPAddressProperty. This change makes use of Shill now exposing these properties nested under a StaticIPConfig and SavedIPConfig dictionary. This also makes the translation between a list of nameservers and a comma-separated string obsolete. BUG=411289 Committed: https://crrev.com/ac2d359b101e4c97455125958db4a999bf26135f Cr-Commit-Position: refs/heads/master@{#306400}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -80 lines) Patch
M chromeos/network/onc/onc_translation_tables.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 3 chunks +15 lines, -18 lines 0 comments Download
M chromeos/network/onc/onc_translator_onc_to_shill.cc View 4 chunks +0 lines, -28 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 4 chunks +18 lines, -22 lines 0 comments Download
M chromeos/test/data/network/shill_ethernet.json View 1 chunk +6 lines, -4 lines 1 comment Download
M chromeos/test/data/network/shill_ethernet_with_ipconfig.json View 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pneubeck (no reviews)
forgot to publish this CL :-/ ptal
6 years ago (2014-12-02 10:26:59 UTC) #2
stevenjb
lgtm https://codereview.chromium.org/762243002/diff/1/chromeos/test/data/network/shill_ethernet.json File chromeos/test/data/network/shill_ethernet.json (right): https://codereview.chromium.org/762243002/diff/1/chromeos/test/data/network/shill_ethernet.json#newcode3 chromeos/test/data/network/shill_ethernet.json:3: "StaticIPConfig": { Ah, I didn't realize that this ...
6 years ago (2014-12-02 16:28:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762243002/1
6 years ago (2014-12-02 16:51:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-02 16:54:21 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ac2d359b101e4c97455125958db4a999bf26135f Cr-Commit-Position: refs/heads/master@{#306400}
6 years ago (2014-12-02 16:55:14 UTC) #7
pfeldman
6 years ago (2014-12-02 17:43:07 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/776603002/ by pfeldman@chromium.org.

The reason for reverting is: Breaks the build:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tes....

Powered by Google App Engine
This is Rietveld 408576698