Issue 778653002: Pixel-snap the bounds in BoxPainter::boundsForDrawingRecorder

Issue 778653002: Pixel-snap the bounds in BoxPainter::boundsForDrawingRecorder (Closed)

Created:
6 years ago by fs

Modified:
6 years ago

Reviewers:
leviw_travelin_and_unemployed, chrishtr

CC:
blink-reviews, blink-reviews-paint_chromium.org, slimming-paint-reviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Pixel-snap the bounds in BoxPainter::boundsForDrawingRecorder A snapped paintRect is used when theme-elements are painted in BoxPainter::paintBoxDecorationBackgroundWithRect. BUG=423071, 438281 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186501

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	LayoutTests/TestExpectations	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/core/paint/BoxPainter.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

chrishtr

Levi does this seem correct to you? It sounds ok but not 100% sure.

6 years ago (2014-12-03 17:26:12 UTC) #4

leviw_travelin_and_unemployed

Yes. The visual overflow rect + the paint offset should properly pixel snap. LGTM.

6 years ago (2014-12-03 22:55:56 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778653002/1

6 years ago (2014-12-04 11:25:29 UTC) #7

commit-bot: I haz the power

6 years ago (2014-12-04 11:27:37 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186501