Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 761953002: Add fast/text to the Slimming Paint virtual testsuite (Closed)

Created:
6 years ago by fs
Modified:
6 years ago
Reviewers:
chrishtr
CC:
blink-reviews, Rik, danakj, krit, f(malita), jbroman, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Add fast/text to the Slimming Paint virtual testsuite fast/text/selection-hard-linebreak.html: Waiting for FramePainter chunks/changes. fast/text/whitespace/normal-after-nowrap-breaking.html (Mac): Off-by-one when painting checkbox. Rounding? Duplicate test expectations where they exist. BUG=423071 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186329

Patch Set 1 #

Patch Set 2 : Update TestExpectations. #

Patch Set 3 : Rebase. #

Patch Set 4 : More expectations #

Patch Set 5 : Drop CTM-fix that landed separately. #

Total comments: 2

Patch Set 6 : Update TestExpectations w/ issue#. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M LayoutTests/NeverFixTests View 1 3 chunks +12 lines, -0 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 3 4 5 11 chunks +17 lines, -0 lines 0 comments Download
M LayoutTests/VirtualTestSuites View 1 chunk +5 lines, -0 lines 0 comments Download
A + LayoutTests/virtual/slimmingpaint/fast/text/README.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
fs
6 years ago (2014-12-02 13:53:47 UTC) #2
chrishtr
https://codereview.chromium.org/761953002/diff/80001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/761953002/diff/80001/LayoutTests/TestExpectations#newcode1400 LayoutTests/TestExpectations:1400: crbug.com/423071 [ Mac ] virtual/slimmingpaint/fast/text/drawBidiText.html [ NeedsRebaseline ] Please ...
6 years ago (2014-12-02 17:51:54 UTC) #3
fs
https://codereview.chromium.org/761953002/diff/80001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/761953002/diff/80001/LayoutTests/TestExpectations#newcode1400 LayoutTests/TestExpectations:1400: crbug.com/423071 [ Mac ] virtual/slimmingpaint/fast/text/drawBidiText.html [ NeedsRebaseline ] On ...
6 years ago (2014-12-02 18:26:26 UTC) #4
chrishtr
lgtm
6 years ago (2014-12-02 18:39:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761953002/100001
6 years ago (2014-12-02 18:39:45 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-02 19:56:14 UTC) #8
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186329

Powered by Google App Engine
This is Rietveld 408576698