Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 778283002: Don't show the shadow for maximized/fullscreen window (Closed)

Created:
6 years ago by oshima
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't show the shadow for maximized/fullscreen window BUG=407966 TEST=covered by unit test. Committed: https://crrev.com/deecdafa38a9effc737acde28e82a32cc527a1b5 Cr-Commit-Position: refs/heads/master@{#309272} Committed: https://crrev.com/1531d38e8a150190c83c87ca6676cb809b39e376 Cr-Commit-Position: refs/heads/master@{#310190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M ui/wm/core/shadow_controller.cc View 3 chunks +10 lines, -1 line 0 comments Download
M ui/wm/core/shadow_controller_unittest.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
oshima
6 years ago (2014-12-05 23:21:05 UTC) #2
sky
LGTM
6 years ago (2014-12-05 23:52:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778283002/1
6 years ago (2014-12-06 00:17:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/23701)
6 years ago (2014-12-06 00:34:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778283002/1
6 years ago (2014-12-19 21:34:34 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 21:48:19 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/deecdafa38a9effc737acde28e82a32cc527a1b5 Cr-Commit-Position: refs/heads/master@{#309272}
6 years ago (2014-12-19 21:49:03 UTC) #14
mohsen
On 2014/12/19 21:49:03, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
6 years ago (2014-12-20 01:55:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778283002/1
5 years, 11 months ago (2015-01-07 00:31:30 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 00:32:49 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 00:33:25 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1531d38e8a150190c83c87ca6676cb809b39e376
Cr-Commit-Position: refs/heads/master@{#310190}

Powered by Google App Engine
This is Rietveld 408576698