Index: Source/platform/fonts/Font.cpp |
diff --git a/Source/platform/fonts/Font.cpp b/Source/platform/fonts/Font.cpp |
index ba3f7245f074d19ea37819d58d269d39dd731aee..1f31b6d0252201f6ffe36113f16d1595182a77a0 100644 |
--- a/Source/platform/fonts/Font.cpp |
+++ b/Source/platform/fonts/Font.cpp |
@@ -259,6 +259,12 @@ float Font::width(const TextRun& run, HashSet<const SimpleFontData*>* fallbackFo |
return result; |
} |
+static bool requiresRecomputingBounds(const Font& font) |
+{ |
+ const FontDescription& fontDescription = font.fontDescription(); |
+ return fontDescription.letterSpacing() < 0 || fontDescription.wordSpacing() < 0; |
+} |
+ |
PassTextBlobPtr Font::buildTextBlob(const GlyphBuffer& glyphBuffer, const FloatRect& bounds, |
bool couldUseLCD) const |
{ |
@@ -266,6 +272,9 @@ PassTextBlobPtr Font::buildTextBlob(const GlyphBuffer& glyphBuffer, const FloatR |
SkTextBlobBuilder builder; |
SkRect skBounds = bounds; |
+ // FIXME: Identify these cases earlier on and avoid using bounds that are |
+ // not visually correct in other places. |
+ const SkRect* skBoundsPtr = requiresRecomputingBounds(*this) ? nullptr : &skBounds; |
bool hasVerticalOffsets = glyphBuffer.hasVerticalOffsets(); |
unsigned i = 0; |
@@ -292,8 +301,8 @@ PassTextBlobPtr Font::buildTextBlob(const GlyphBuffer& glyphBuffer, const FloatR |
unsigned count = i - start; |
const SkTextBlobBuilder::RunBuffer& buffer = hasVerticalOffsets |
- ? builder.allocRunPos(paint, count, &skBounds) |
- : builder.allocRunPosH(paint, count, 0, &skBounds); |
+ ? builder.allocRunPos(paint, count, skBoundsPtr) |
+ : builder.allocRunPosH(paint, count, 0, skBoundsPtr); |
const uint16_t* glyphs = glyphBuffer.glyphs(start); |
const float* offsets = glyphBuffer.offsets(start); |