Uninline google::protobuf::internal::GetEmptystring()

Uninline several internal protobuf helpers.

This saves 576KiB on a release build.

BUG=none

Committed: https://crrev.com/daaa100e8cceaa13d562ece174fd203b2aca8a7e
Cr-Commit-Position: refs/heads/master@{#307332}

[dcheng, 2014-12-05 18:48:41]

dcheng@chromium.org changed reviewers:
+ cpu@chromium.org

[dcheng, 2014-12-05 18:49:11]

I don't think protobufs should be on a hot path for Chromium, so out-of-lining
this code shouldn't have a measurable performance impact.

[cpu_(ooo_6.6-7.5), 2014-12-05 22:38:25]

looks good but I only review new 3rd party libraries, there should be an owners
file at the root of this lib and somebody there needs to review.

[dcheng, 2014-12-05 23:43:16]

Unfortunately, there isn't an OWNERS file in third_party/protobuf. Would you be
willing to rubber stamp this for now, and I'll try to get the OWNERS file
populated appropriately after this?

[dcheng, 2014-12-08 19:33:03]

dcheng@chromium.org changed reviewers:
+ scottmg@chromium.org

[dcheng, 2014-12-08 19:33:03]

+scottmg, since he will be an owner soon =)

[scottmg, 2014-12-08 19:38:45]

On 2014/12/08 19:33:03, dcheng wrote:
> +scottmg, since he will be an owner soon =)

Sneaky!

That is a frightening amount of size.

Please upload upstream with a note about the space savings to see if upstream is
interested, and add a link to that here.

lgtm

[dcheng, 2014-12-08 20:09:42]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-12-08 20:11:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/778203003/60001

[commit-bot: I haz the power, 2014-12-08 20:59:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-08 21:00:11]

Patchset 4 (id:??) landed as
https://crrev.com/daaa100e8cceaa13d562ece174fd203b2aca8a7e
Cr-Commit-Position: refs/heads/master@{#307332}

[dcheng, 2014-12-08 21:57:05]

On 2014/12/08 at 21:00:11, commit-bot wrote:
> Patchset 4 (id:??) landed as
https://crrev.com/daaa100e8cceaa13d562ece174fd203b2aca8a7e
> Cr-Commit-Position: refs/heads/master@{#307332}

Mentioned this upstream at https://github.com/google/protobuf/issues/125; we'll
see what they say.

[Will Harris, 2014-12-16 08:14:01]

Wow. Much saving. Many Kb.