third_party/protobuf/src/google/protobuf/generated_message_util.cc - Issue 778203003: Uninline google::protobuf::internal::GetEmptystring()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/src/google/protobuf/generated_message_util.cc

Issue 778203003: Uninline google::protobuf::internal::GetEmptystring() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Expoert uninlined GoogleOnceInit Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/protobuf/src/google/protobuf/generated_message_util.h ('k') | third_party/protobuf/src/google/protobuf/stubs/once.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/protobuf/src/google/protobuf/generated_message_util.cc

diff --git a/third_party/protobuf/src/google/protobuf/generated_message_util.cc b/third_party/protobuf/src/google/protobuf/generated_message_util.cc

index 794be3571053165bf5b56e75a3b5e8afd6d9edf7..92882d79ce7ae63cbf1964fc20474a0db6115609 100644

--- a/third_party/protobuf/src/google/protobuf/generated_message_util.cc

+++ b/third_party/protobuf/src/google/protobuf/generated_message_util.cc

@@ -54,6 +54,11 @@ void InitEmptyString() {

empty_string_ = new std::string();

}

+const ::std::string& GetEmptyString() {

+ GoogleOnceInit(&empty_string_once_init_, &InitEmptyString);

+ return *empty_string_;

} // namespace internal

} // namespace protobuf

} // namespace google