Issue 778183002: [android_webview] Correctly handle ContextWrapper in AwContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 778183002: [android_webview] Correctly handle ContextWrapper in AwContents. (Closed)

Created:
6 years ago by mkosiba (inactive)

Modified:
6 years ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Project:
chromium

Visibility:
Public.

[android_webview] Correctly handle ContextWrapper in AwContents. Having a ContextWrapper passed in as the AwContents Context parameter was causing us to use the wrong kind of window object which in turn resulted in popup dialogs not being displayed. BUG=434695 Review URL: https://codereview.chromium.org/756983002 TBR=mkosiba@chromium.org Cr-Commit-Position: refs/heads/master@{#305796} (cherry picked from commit 214620e444390c1442a62d79499a82562ebe492d) Committed: https://chromium.googlesource.com/chromium/src/+/2e6a4f17ca1f67c06c19d637ca7c940d75d64779

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -16 lines)			Patch
M	android_webview/java/src/org/chromium/android_webview/AwContents.java	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java	View	3 chunks	+1 line, -13 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	3 chunks	+18 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

mkosiba (inactive)

6 years ago (2014-12-05 16:49:50 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2e6a4f17ca1f67c06c19d637ca7c940d75d64779 (presubmit successful).