Chromium Code Reviews

Issue 756983002: [android_webview] Correctly handle ContextWrapper in AwContents. (Closed)

Created:
6 years ago by mkosiba (inactive)
Modified:
6 years ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[android_webview] Correctly handle ContextWrapper in AwContents. Having a ContextWrapper passed in as the AwContents Context parameter was causing us to use the wrong kind of window object which in turn resulted in popup dialogs not being displayed. BUG=434695 Committed: https://crrev.com/214620e444390c1442a62d79499a82562ebe492d Cr-Commit-Position: refs/heads/master@{#305796}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+22 lines, -16 lines)
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +3 lines, -2 lines 0 comments
M content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java View 3 chunks +1 line, -13 lines 0 comments
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 3 chunks +18 lines, -1 line 0 comments

Messages

Total messages: 8 (3 generated)
mkosiba (inactive)
PTAL. The WebView wraps the Context it gets passed in a ContextWrapper so we can ...
6 years ago (2014-11-25 13:46:16 UTC) #3
Ted C
lgtm
6 years ago (2014-11-25 18:26:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756983002/20001
6 years ago (2014-11-26 10:00:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-26 10:50:57 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-26 10:51:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/214620e444390c1442a62d79499a82562ebe492d
Cr-Commit-Position: refs/heads/master@{#305796}

Powered by Google App Engine