Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 778043005: Remove RenderLayer::collectFragments. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove RenderLayer::collectFragments. Sky always has exactly one per RenderLayer. This patch gets rid of the hitTestLayer use of LayerFragment and gets paintLayerContents to create the list of fragments itself since it's the only caller. Also, delete dead code from LayerFragment.h. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4a3b676dc3387b64575d4a407c90fa8a6f466f4c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -76 lines) Patch
M sky/engine/core/rendering/LayerFragment.h View 1 chunk +0 lines, -23 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 8 chunks +21 lines, -49 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
ojan
6 years ago (2014-12-08 21:20:55 UTC) #2
abarth-chromium
lgtm
6 years ago (2014-12-08 23:34:00 UTC) #4
ojan
Committed patchset #1 (id:1) manually as 4a3b676dc3387b64575d4a407c90fa8a6f466f4c.
6 years ago (2014-12-09 00:37:58 UTC) #5
eseidel
https://codereview.chromium.org/778043005/diff/1/sky/engine/core/rendering/RenderLayer.cpp File sky/engine/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/778043005/diff/1/sky/engine/core/rendering/RenderLayer.cpp#newcode1572 sky/engine/core/rendering/RenderLayer.cpp:1572: if (isSelfPaintingLayer() && !foregroundRect.intersects(hitTestLocation)) { This ! looks wrong.
6 years ago (2014-12-10 21:43:50 UTC) #6
eseidel
6 years ago (2014-12-10 22:42:25 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/788383002/ by eseidel@chromium.org.

The reason for reverting is: This broke hit testing.  Hit testing always returns
the root node now. :).

Powered by Google App Engine
This is Rietveld 408576698