List marker pseudo elements.

Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 1326 matching lines @@
     ContainerNode::attach(context);
 
     createPseudoElementIfNeeded(AFTER);
     createPseudoElementIfNeeded(BACKDROP);
 
     // We create the first-letter element after the :before, :after and
     // children are attached because the first letter text could come
     // from any of them.
     createPseudoElementIfNeeded(FIRST_LETTER);
 
+    // The marker has to come after the other content, including the BEFORE pseudo
+    // element so make sure we create it last.
+    if (RuntimeEnabledFeatures::listMarkerPseudoElementEnabled())
+        createPseudoElementIfNeeded(MARKER);
+
     if (hasRareData() && !renderer()) {
         if (ActiveAnimations* activeAnimations = elementRareData()->activeAnimations()) {
             activeAnimations->cssAnimations().cancel();
             activeAnimations->setAnimationStyleChange(false);
         }
     }
+
+    // If our parent has a marker pseudo element we need to inform them that we
+    // were attached as they may need to move the list marker.

[Julien - ping for review, 2014/12/05 19:44:03]

Move the list maker? Usually moving renderers is a bad idea as it may leave
pointers around (less and less the case but we have had a lot of issue with that
in the past)

[dsinclair, 2015/01/23 20:46:36]

Yea, it sucks but we still have to do it. It's possible we've inserted something
before the list marker, or removed something that effects the list marker. We
have to get the parent to look at the tree and see if everything is correct.

This worked before because we'd do it in layout. It was the same concept, in
that it would look at who the line boxes were and decide where the list marker
goes.

+    if (RuntimeEnabledFeatures::listMarkerPseudoElementEnabled() && parentNode() && parentNode()->isElementNode()) {
+        if (PseudoElement* pseudoElement = toElement(parentNode())->pseudoElement(MARKER)) {
+            bool neededRecalc = pseudoElement->needsStyleRecalc();
+            pseudoElement->setNeedsStyleRecalc(LocalStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::PseudoClass));
+
+            // If style recalc is currently executing, and we have already been recalc'd
+            // we need to tell our parent to do the recalc again because we need to
+            // re-initialize the first letter state. This can happen for things like
+            // RenderQuote where quotes processed later can effect things already styled.
+            if (document().inStyleRecalc() && !neededRecalc)
+                pseudoElement->recalcStyle(UpdatePseudoElements);
+        }
+    }
 }
 
 void Element::detach(const AttachContext& context)
 {
     HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
     cancelFocusAppearanceUpdate();
     removeCallbackSelectors();
     if (hasRareData()) {
         ElementRareData* data = elementRareData();
         data->clearPseudoElements();
@@ skipping 136 matching lines @@
         if (change > UpdatePseudoElements || childNeedsStyleRecalc()) {
             for (ShadowRoot* root = youngestShadowRoot(); root; root = root->olderShadowRoot()) {
                 if (root->shouldCallRecalcStyle(change))
                     root->recalcStyle(change);
             }
             recalcChildStyle(change);
         }
 
         updatePseudoElement(AFTER, change);
         updatePseudoElement(BACKDROP, change);
+        if (RuntimeEnabledFeatures::listMarkerPseudoElementEnabled())
+            updatePseudoElement(MARKER, change);
 
         // If our children have changed then we need to force the first-letter
         // checks as we don't know if they effected the first letter or not.
         // This can be seen when a child transitions from floating to
         // non-floating we have to take it into account for the first letter.
         updatePseudoElement(FIRST_LETTER, childNeedsStyleRecalc() ? Force : change);
 
         clearChildNeedsStyleRecalc();
     }
 
@@ skipping 987 matching lines @@
 
         // PseudoElement styles hang off their parent element's style so if we needed
         // a style recalc we should Force one on the pseudo.
         // FIXME: We should figure out the right text sibling to pass.
         element->recalcStyle(change == UpdatePseudoElements ? Force : change);
 
         // Wait until our parent is not displayed or pseudoElementRendererIsNeeded
         // is false, otherwise we could continuously create and destroy PseudoElements
         // when RenderObject::isChildAllowed on our parent returns false for the
         // PseudoElement's renderer for each style recalc.
-        if (!renderer() || !pseudoElementRendererIsNeeded(renderer()->getCachedPseudoStyle(pseudoId)))
+        if (!renderer() ||
+            (!pseudoElementRendererIsNeeded(renderer()->getCachedPseudoStyle(pseudoId)) && (pseudoId == MARKER && renderer()->style()->display() != LIST_ITEM)))
             elementRareData()->setPseudoElement(pseudoId, nullptr);
     } else if (pseudoId == FIRST_LETTER && element && change >= UpdatePseudoElements && !FirstLetterPseudoElement::firstLetterTextRenderer(*element)) {
         // This can happen if we change to a float, for example. We need to cleanup the
         // first-letter pseudoElement and then fix the text of the original remaining
         // text renderer.
         // This can be seen in Test 7 of fast/css/first-letter-removed-added.html
         elementRareData()->setPseudoElement(pseudoId, nullptr);
     } else if (change >= UpdatePseudoElements) {
         createPseudoElementIfNeeded(pseudoId);
     }
@@ skipping 15 matching lines @@
             element->reattach();
         else
             elementRareData()->setPseudoElement(FIRST_LETTER, nullptr);
         return true;
     }
     return false;
 }
 
 void Element::createPseudoElementIfNeeded(PseudoId pseudoId)
 {
-    if (isPseudoElement())
+    if (isPseudoElement() && (pseudoId != MARKER || isMarkerPseudoElement()))
         return;
 
     // Document::ensureStyleResolver is not inlined and shows up on profiles, avoid it here.
     StyleEngine* engine = document().styleEngine();
     RefPtrWillBeRawPtr<PseudoElement> element = engine->ensureResolver().createPseudoElementIfNeeded(*this, pseudoId);
     if (!element)
         return;
-
     if (pseudoId == BACKDROP)
         document().addToTopLayer(element.get(), this);
+
     element->insertedInto(this);
     element->attach();
 
     InspectorInstrumentation::pseudoElementCreated(element.get());
 
     ensureElementRareData().setPseudoElement(pseudoId, element.release());
 }
 
 PseudoElement* Element::pseudoElement(PseudoId pseudoId) const
 {
@@ skipping 733 matching lines @@
         return wrapper;
 
     CustomElementBinding* binding = perContextData->customElementBinding(customElementDefinition());
 
     wrapper->SetPrototype(binding->prototype());
 
     return V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperType, wrapper);
 }
 
 } // namespace blink