Misc. warning fixes/cleanup

Misc. warning fixes/cleanup

BUG=81439
TEST=none

Committed: https://crrev.com/2209d5e44d1271b3c60d7517639697759b1f5275
Cr-Commit-Position: refs/heads/master@{#308182}

[Peter Kasting, 2014-12-06 00:12:17]

pkasting@chromium.org changed reviewers:
+ bbudge@chromium.org, brettw@chromium.org

[Peter Kasting, 2014-12-06 00:12:18]

brettw as an overall OWNERS stamp (changes mostly too trivial to find multiple
owners).

bbudge to answer my concern about the NaCl code below.

https://codereview.chromium.org/777853003/diff/1/chrome/common/worker_thread_...
File chrome/common/worker_thread_ticker.h (left):

https://codereview.chromium.org/777853003/diff/1/chrome/common/worker_thread_...
chrome/common/worker_thread_ticker.h:63: int tick_interval() const {
Unused.

https://codereview.chromium.org/777853003/diff/1/components/nacl/loader/nacl_...
File components/nacl/loader/nacl_ipc_adapter.cc (right):

https://codereview.chromium.org/777853003/diff/1/components/nacl/loader/nacl_...
components/nacl/loader/nacl_ipc_adapter.cc:827: header.num_fds =
static_cast<uint16>(rewritten_msg->desc_count());
What if desc_count() doesn't fit in a uint16?  Is that possible?  Should we
checked_cast<> here?

[bbudge, 2014-12-06 01:30:28]

https://codereview.chromium.org/777853003/diff/1/components/nacl/loader/nacl_...
File components/nacl/loader/nacl_ipc_adapter.cc (right):

https://codereview.chromium.org/777853003/diff/1/components/nacl/loader/nacl_...
components/nacl/loader/nacl_ipc_adapter.cc:827: header.num_fds =
static_cast<uint16>(rewritten_msg->desc_count());
On 2014/12/06 00:12:18, Peter Kasting wrote:
> What if desc_count() doesn't fit in a uint16?  Is that possible?  Should we
> checked_cast<> here?

These messages are from the renderer or browser processes, so I think the number
of fds is very small (1 or 2 at most) and we don't worry about attacks from this
direction.

[bbudge, 2014-12-06 01:30:39]

lgtm

[Peter Kasting, 2014-12-09 23:44:33]

Ping for brettw

[brettw, 2014-12-12 03:36:35]

lgtm

[Peter Kasting, 2014-12-12 21:38:10]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-12-12 21:39:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/777853003/1

[commit-bot: I haz the power, 2014-12-12 22:25:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-12 22:26:37]

Patchset 1 (id:??) landed as
https://crrev.com/2209d5e44d1271b3c60d7517639697759b1f5275
Cr-Commit-Position: refs/heads/master@{#308182}