Misc. warning fixes/cleanup

components/nacl/loader/nacl_ipc_adapter.cc

Index: components/nacl/loader/nacl_ipc_adapter.cc
diff --git a/components/nacl/loader/nacl_ipc_adapter.cc b/components/nacl/loader/nacl_ipc_adapter.cc
index 5d28152366e62b93b8ea2b68b371a675442ff809..571249a0cc00a7a76af5fd1ef7622f38d624dee7 100644
--- a/components/nacl/loader/nacl_ipc_adapter.cc
+++ b/components/nacl/loader/nacl_ipc_adapter.cc
@@ -824,7 +824,7 @@ void NaClIPCAdapter::SaveMessage(const IPC::Message& msg,
   header.routing = msg.routing_id();
   header.type = msg.type();
   header.flags = msg.flags();
-  header.num_fds = static_cast<int>(rewritten_msg->desc_count());
+  header.num_fds = static_cast<uint16>(rewritten_msg->desc_count());

[Peter Kasting, 2014/12/06 00:12:18]

What if desc_count() doesn't fit in a uint16?  Is that possible?  Should we
checked_cast<> here?

[bbudge, 2014/12/06 01:30:28]

These messages are from the renderer or browser processes, so I think the number
of fds is very small (1 or 2 at most) and we don't worry about attacks from this
direction.

 
   rewritten_msg->SetData(header, msg.payload(), msg.payload_size());
   locked_data_.to_be_received_.push(rewritten_msg);