Ensure the ExtensionSystem is ready before initializing an ExtensionAppModelBuilder

chrome/browser/ui/app_list/app_list_controller_delegate.cc

Index: chrome/browser/ui/app_list/app_list_controller_delegate.cc
diff --git a/chrome/browser/ui/app_list/app_list_controller_delegate.cc b/chrome/browser/ui/app_list/app_list_controller_delegate.cc
index e6bff3e771bcaadb6170e8bead66a9888fc27067..4ff275dcb4ac164ca285d378128ff62e1319ac4f 100644
--- a/chrome/browser/ui/app_list/app_list_controller_delegate.cc
+++ b/chrome/browser/ui/app_list/app_list_controller_delegate.cc
@@ -161,6 +161,7 @@ void AppListControllerDelegate::GetApps(Profile* profile,
                                         ExtensionSet* out_apps) {
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile)->extension_service();
+  DCHECK(service);

[tapted, 2013/11/20 11:03:25]

maybe CHECK() - opinions?

   if (!service)
     return;

[stevenjb, 2013/11/20 19:41:15]

We shouldn't have both {D}CHECK(service) and a !service test. {D}CHECK indicates
a code path that should never happen.

I assume this was just added for testing and should be removed; there may be
tests where service is NULL? If not, the early exit should be removed (and the
code will crash immediately below if service is NULL).

[tapted, 2013/11/21 03:29:56]

Yep - bot runs suggest that the separate !service check is no longer necessary
for tests, with the other changes in this CL. Now just DCHECK (Done.)

   out_apps->InsertAll(*service->extensions());