Ensure the ExtensionSystem is ready before initializing an ExtensionAppModelBuilder

chrome/browser/ui/app_list/app_list_controller_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
 
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/install_tracker_factory.h"
 #include "chrome/browser/extensions/management_policy.h"
@@ skipping 143 matching lines @@
     Profile* profile) {
   if (extensions::ExtensionSystem::Get(profile)->extension_service())
     return extensions::InstallTrackerFactory::GetForProfile(profile);
   return NULL;
 }
 
 void AppListControllerDelegate::GetApps(Profile* profile,
                                         ExtensionSet* out_apps) {
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile)->extension_service();
+  DCHECK(service);

[tapted, 2013/11/20 11:03:25]

maybe CHECK() - opinions?

   if (!service)
     return;

[stevenjb, 2013/11/20 19:41:15]

We shouldn't have both {D}CHECK(service) and a !service test. {D}CHECK indicates
a code path that should never happen.

I assume this was just added for testing and should be removed; there may be
tests where service is NULL? If not, the early exit should be removed (and the
code will crash immediately below if service is NULL).

[tapted, 2013/11/21 03:29:56]

Yep - bot runs suggest that the separate !service check is no longer necessary
for tests, with the other changes in this CL. Now just DCHECK (Done.)

   out_apps->InsertAll(*service->extensions());
   out_apps->InsertAll(*service->disabled_extensions());
   out_apps->InsertAll(*service->terminated_extensions());
 }