Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 777543002: Create hosted app shims on Mac. (Closed)

Created:
6 years ago by mitchellj
Modified:
6 years ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Create hosted app shims on Mac. - Added ability to create app shim on Mac. - Displays alert for adding hosted app on Mac. - Added ability to change app name and whether it should be opened in new tab upon creation. - App shim is revealed in Finder after creation. BUG=438100 Committed: https://crrev.com/1c30102b4a2c4a9102c1c9bd32a19cfffb48b3f3 Cr-Commit-Position: refs/heads/master@{#307806}

Patch Set 1 #

Total comments: 16

Patch Set 2 : Addressed comments and fixed formatting #

Patch Set 3 : Removed unnecessary forward declaration #

Total comments: 12

Patch Set 4 : Addressed further comments and refactored code #

Total comments: 4

Patch Set 5 : Further refactoring and comments #

Total comments: 14

Patch Set 6 : Fixed leaks and redefined UI constants #

Total comments: 2

Patch Set 7 : Renamed UI constants and added comments #

Patch Set 8 : Fix broken unit tests #

Patch Set 9 : Removed global static initialisers #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -31 lines) Patch
M chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc View 1 4 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_apitest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/launch_util.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 4 5 6 7 8 5 chunks +102 lines, -1 line 1 comment Download
M chrome/browser/web_applications/web_app.cc View 1 2 3 4 3 chunks +29 lines, -3 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.h View 1 2 3 4 5 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 2 3 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/management/test/launchType.js View 1 2 3 4 5 6 7 2 chunks +1 line, -4 lines 0 comments Download
M extensions/browser/api/management/management_api.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (5 generated)
mitchellj
6 years ago (2014-12-03 01:37:21 UTC) #2
jackhou1
Looking pretty good. You should update the CL title to make it clear that this ...
6 years ago (2014-12-03 05:12:05 UTC) #3
mitchellj
https://codereview.chromium.org/777543002/diff/1/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc File chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc (right): https://codereview.chromium.org/777543002/diff/1/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc#newcode175 chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc:175: (extension->is_platform_app() || extension->is_hosted_app()) On 2014/12/03 05:12:05, jackhou1 wrote: > ...
6 years ago (2014-12-04 04:53:53 UTC) #4
jackhou1
https://codereview.chromium.org/777543002/diff/40001/chrome/browser/ui/cocoa/browser_window_cocoa.mm File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right): https://codereview.chromium.org/777543002/diff/40001/chrome/browser/ui/cocoa/browser_window_cocoa.mm#newcode549 chrome/browser/ui/cocoa/browser_window_cocoa.mm:549: const int kIconPreviewTargetSize = 64; Move this constant up ...
6 years ago (2014-12-04 06:37:11 UTC) #5
mitchellj
https://codereview.chromium.org/777543002/diff/40001/chrome/browser/ui/cocoa/browser_window_cocoa.mm File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right): https://codereview.chromium.org/777543002/diff/40001/chrome/browser/ui/cocoa/browser_window_cocoa.mm#newcode549 chrome/browser/ui/cocoa/browser_window_cocoa.mm:549: const int kIconPreviewTargetSize = 64; On 2014/12/04 06:37:11, jackhou1 ...
6 years ago (2014-12-04 22:48:40 UTC) #6
jackhou1
lgtm with some comments https://codereview.chromium.org/777543002/diff/60001/chrome/browser/ui/cocoa/browser_window_cocoa.mm File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right): https://codereview.chromium.org/777543002/diff/60001/chrome/browser/ui/cocoa/browser_window_cocoa.mm#newcode554 chrome/browser/ui/cocoa/browser_window_cocoa.mm:554: web_app_info.icons[web_app_info.icons.size() - 1]; web_app_info.icons.back() gives ...
6 years ago (2014-12-05 01:52:01 UTC) #7
calamity
https://codereview.chromium.org/777543002/diff/60001/chrome/browser/web_applications/web_app.cc File chrome/browser/web_applications/web_app.cc (right): https://codereview.chromium.org/777543002/diff/60001/chrome/browser/web_applications/web_app.cc#newcode275 chrome/browser/web_applications/web_app.cc:275: platform_app = platform_app || extension->is_hosted_app(); Drive-by nit: If this ...
6 years ago (2014-12-05 02:22:22 UTC) #8
mitchellj
https://codereview.chromium.org/777543002/diff/60001/chrome/browser/ui/cocoa/browser_window_cocoa.mm File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right): https://codereview.chromium.org/777543002/diff/60001/chrome/browser/ui/cocoa/browser_window_cocoa.mm#newcode554 chrome/browser/ui/cocoa/browser_window_cocoa.mm:554: web_app_info.icons[web_app_info.icons.size() - 1]; On 2014/12/05 01:52:01, jackhou1 wrote: > ...
6 years ago (2014-12-05 05:07:49 UTC) #9
mitchellj
Ben, could you please review as owner launch_util.cc? Robert, could you please review as owner ...
6 years ago (2014-12-05 05:12:13 UTC) #11
Robert Sesek
https://codereview.chromium.org/777543002/diff/80001/chrome/browser/ui/cocoa/browser_window_cocoa.mm File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right): https://codereview.chromium.org/777543002/diff/80001/chrome/browser/ui/cocoa/browser_window_cocoa.mm#newcode80 chrome/browser/ui/cocoa/browser_window_cocoa.mm:80: const NSRect kAppTitleTextFieldSize = {{0, 24}, {200, 22}}; Where ...
6 years ago (2014-12-05 18:30:37 UTC) #12
benwells
c/b/e lgtm
6 years ago (2014-12-08 02:14:21 UTC) #13
mitchellj
https://codereview.chromium.org/777543002/diff/80001/chrome/browser/ui/cocoa/browser_window_cocoa.mm File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right): https://codereview.chromium.org/777543002/diff/80001/chrome/browser/ui/cocoa/browser_window_cocoa.mm#newcode80 chrome/browser/ui/cocoa/browser_window_cocoa.mm:80: const NSRect kAppTitleTextFieldSize = {{0, 24}, {200, 22}}; On ...
6 years ago (2014-12-09 01:39:53 UTC) #14
Robert Sesek
LGTM % one comment https://codereview.chromium.org/777543002/diff/100001/chrome/browser/ui/cocoa/browser_window_cocoa.mm File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right): https://codereview.chromium.org/777543002/diff/100001/chrome/browser/ui/cocoa/browser_window_cocoa.mm#newcode83 chrome/browser/ui/cocoa/browser_window_cocoa.mm:83: const NSSize kViewSize = NSMakeSize(200, ...
6 years ago (2014-12-09 02:20:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777543002/120001
6 years ago (2014-12-09 02:57:00 UTC) #17
mitchellj
https://codereview.chromium.org/777543002/diff/100001/chrome/browser/ui/cocoa/browser_window_cocoa.mm File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right): https://codereview.chromium.org/777543002/diff/100001/chrome/browser/ui/cocoa/browser_window_cocoa.mm#newcode83 chrome/browser/ui/cocoa/browser_window_cocoa.mm:83: const NSSize kViewSize = NSMakeSize(200, 46); On 2014/12/09 02:20:52, ...
6 years ago (2014-12-09 04:23:40 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/12722)
6 years ago (2014-12-09 08:22:04 UTC) #20
mitchellj
Ben, could you please review the files modified in patch set 8? I had to ...
6 years ago (2014-12-10 02:28:18 UTC) #21
mitchellj
https://codereview.chromium.org/777543002/diff/160001/chrome/browser/ui/cocoa/browser_window_cocoa.mm File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right): https://codereview.chromium.org/777543002/diff/160001/chrome/browser/ui/cocoa/browser_window_cocoa.mm#newcode88 chrome/browser/ui/cocoa/browser_window_cocoa.mm:88: const int kBookmarkAppBubbleViewHeight = 46; Robert, tapted@ warned that ...
6 years ago (2014-12-10 02:48:45 UTC) #22
benwells
On 2014/12/10 02:28:18, mitchellj wrote: > Ben, could you please review the files modified in ...
6 years ago (2014-12-10 02:51:26 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777543002/160001
6 years ago (2014-12-10 22:37:22 UTC) #25
commit-bot: I haz the power
Committed patchset #9 (id:160001)
6 years ago (2014-12-11 00:38:59 UTC) #26
commit-bot: I haz the power
6 years ago (2014-12-11 00:40:02 UTC) #27
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/1c30102b4a2c4a9102c1c9bd32a19cfffb48b3f3
Cr-Commit-Position: refs/heads/master@{#307806}

Powered by Google App Engine
This is Rietveld 408576698