Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Unified Diff: chrome/browser/web_applications/web_app_mac.h

Issue 777543002: Create hosted app shims on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed global static initialisers Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_applications/web_app_mac.h
diff --git a/chrome/browser/web_applications/web_app_mac.h b/chrome/browser/web_applications/web_app_mac.h
index 7c2ff41676a066303c52b8f4fd74904a9396c338..49964a300097e6587c354d7e3cb75f76563df761 100644
--- a/chrome/browser/web_applications/web_app_mac.h
+++ b/chrome/browser/web_applications/web_app_mac.h
@@ -35,6 +35,12 @@ void MaybeLaunchShortcut(const ShortcutInfo& shortcut_info);
// Rebuild the shortcut and relaunch it.
bool MaybeRebuildShortcut(const base::CommandLine& command_line);
+// Reveals app shim in Finder given a profile and app.
+// Calls RevealAppShimInFinderForAppOnFileThread and schedules it
+// on the FILE thread.
+void RevealAppShimInFinderForApp(Profile* profile,
+ const extensions::Extension* app);
+
// Creates a shortcut for a web application. The shortcut is a stub app
// that simply loads the browser framework and runs the given app.
class WebAppShortcutCreator {
@@ -66,15 +72,15 @@ class WebAppShortcutCreator {
void DeleteShortcuts();
bool UpdateShortcuts();
+ // Show the bundle we just generated in the Finder.
+ virtual void RevealAppShimInFinder() const;
+
protected:
// Returns a path to an app bundle with the given id. Or an empty path if no
// matching bundle was found.
// Protected and virtual so it can be mocked out for testing.
virtual base::FilePath GetAppBundleById(const std::string& bundle_id) const;
- // Show the bundle we just generated in the Finder.
- virtual void RevealAppShimInFinder() const;
-
private:
FRIEND_TEST_ALL_PREFIXES(WebAppShortcutCreatorTest, DeleteShortcuts);
FRIEND_TEST_ALL_PREFIXES(WebAppShortcutCreatorTest, UpdateIcon);

Powered by Google App Engine
This is Rietveld 408576698