Skeleton code for experiment setup, which will determine should "Allow to collect URL?" bubble be s…

components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc

Index: components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
diff --git a/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc b/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
index 12a4c04f811969e16fc26977fccbe616ea3d133d..88a278bc5aa388cd82eef6b78bafdac21b1121bf 100644
--- a/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
+++ b/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
@@ -5,18 +5,44 @@
 #include "components/password_manager/core/browser/password_manager_url_collection_experiment.h"
 
 #include "base/files/scoped_temp_dir.h"
+#include "base/metrics/field_trial.h"
+#include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/testing_pref_service.h"
+#include "components/password_manager/core/common/password_manager_pref_names.h"
+#include "components/variations/entropy_provider.h"
+#include "components/variations/variations_associated_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
+void SetupMaybeShowBubbleExperimentGroup() {
+  ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+      password_manager::urls_collection_experiment::kExperimentName,
+      password_manager::urls_collection_experiment::kGroupMaybeShowBubble));
+}
+
+void SetupNeverShowBubbleExperimentGroup() {
+  ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+      password_manager::urls_collection_experiment::kExperimentName,
+      password_manager::urls_collection_experiment::kGroupNeverShowBubble));
+}
+
+}  // namespace
+
 class PasswordManagerUrlsCollectionExperimentTest : public testing::Test {
  public:
+  void SetUp() override {
+    pref_service_.registry()->RegisterBooleanPref(
+        password_manager::prefs::kWasAllowToCollectURLBubbleShown, false);
+    field_trial_list_.reset(
+        new base::FieldTrialList(new metrics::SHA1EntropyProvider("foo")));
+  }
   PrefService* prefs() { return &pref_service_; }

[vabr (Chromium), 2014/12/08 11:19:33]

nit: Please add a blank line above line 41.

[melandory, 2014/12/08 13:05:31]

Done.

 
  private:
   TestingPrefServiceSimple pref_service_;
+  scoped_ptr<base::FieldTrialList> field_trial_list_;

[vabr (Chromium), 2014/12/08 11:19:33]

Could this be done without the scoped_ptr, just aggregating base::FieldTrialList
directly, and initialising it in the initialiser list of the test constructor?

[melandory, 2014/12/08 13:05:31]

Done.

 };
 
 TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestDefault) {
@@ -24,4 +50,22 @@ TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestDefault) {
       password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
 }
 
-}  // namespace
+TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestMaybeShowBubbleGroup) {
+  SetupMaybeShowBubbleExperimentGroup();
+  EXPECT_FALSE(

[vabr (Chromium), 2014/12/08 11:19:34]

optional: Maybe add a TODO(melandory) + bug URL about this expectation being
just temporary, until the code starts being able to show the bubble to the user.

[melandory, 2014/12/08 13:05:31]

Done.

+      password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
+}
+
+TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestNeverShowBubbleGroup) {
+  SetupNeverShowBubbleExperimentGroup();
+  EXPECT_FALSE(
+      password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
+}
+
+TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestBubbleWasAlreadyShown) {
+  SetupMaybeShowBubbleExperimentGroup();
+  prefs()->SetBoolean(password_manager::prefs::kWasAllowToCollectURLBubbleShown,
+                      true);
+  EXPECT_FALSE(
+      password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
+}