Chromium Code Reviews| Index: components/password_manager/core/browser/password_manager_url_collection_experiment.cc |
| diff --git a/components/password_manager/core/browser/password_manager_url_collection_experiment.cc b/components/password_manager/core/browser/password_manager_url_collection_experiment.cc |
| index b8d66c5e87d38d9a328cc0c149cd260f379546f6..cda603a3d84a185df2ab7463b74a4e2fb0c6bd1e 100644 |
| --- a/components/password_manager/core/browser/password_manager_url_collection_experiment.cc |
| +++ b/components/password_manager/core/browser/password_manager_url_collection_experiment.cc |
| @@ -2,17 +2,53 @@ |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| -#include "base/prefs/pref_service.h" |
| #include "components/password_manager/core/browser/password_manager_url_collection_experiment.h" |
| +#include "base/metrics/field_trial.h" |
| +#include "base/prefs/pref_service.h" |
| +#include "components/password_manager/core/common/password_manager_pref_names.h" |
| +#include "components/pref_registry/pref_registry_syncable.h" |
| + |
| namespace password_manager { |
| namespace urls_collection_experiment { |
| +namespace { |
| + |
| +bool MaybeShowBubbleExperiment(PrefService* prefs) { |
| + // TODO(melandory): Make decision based on Finch experiment parameters. |
| + return false; |
| +} |
| + |
| +} // namespace |
| + |
| +void RegisterPrefs(user_prefs::PrefRegistrySyncable* registry) { |
| + registry->RegisterBooleanPref( |
| + password_manager::prefs::kWasAllowToCollectURLBubbleShown, |
| + false, // bubble hasn't been shown yet |
| + user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); |
| +} |
| + |
| +const char kExperimentName[] = "AksToSubmitURLBubble"; |
|
vabr (Chromium)
2014/12/08 11:19:33
typo: Aks->Ask
melandory
2014/12/08 13:05:31
Done.
|
| +const char kGroupMaybeShowBubble[] = "ShowBubble"; |
| +const char kGroupNeverShowBubble[] = "NeverShowBubble"; |
| + |
| bool ShouldShowBubble(PrefService* prefs) { |
| - // TODO(melandory) Make descision based on Finch experiment. |
| + if (prefs->GetBoolean(prefs::kWasAllowToCollectURLBubbleShown)) { |
| + if (!base::FieldTrialList::TrialExists(kExperimentName)) |
| + return false; |
| + std::string group_name = |
| + base::FieldTrialList::FindFullName(kExperimentName); |
| + if (group_name == kGroupMaybeShowBubble) |
| + return MaybeShowBubbleExperiment(prefs); |
| + } |
| // "Do not show" is the default case. |
| return false; |
| } |
| +void RecordBubbleClosed(PrefService* prefs) { |
| + prefs->SetBoolean(password_manager::prefs::kWasAllowToCollectURLBubbleShown, |
| + true); |
| +} |
| + |
| } // namespace urls_collection_experiment |
| } // namespace password_manager |